[GitHub] [spark] HyukjinKwon commented on a change in pull request #27707: [SPARK-30958][SQL] do not set default era for DateTimeFormatter

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #27707: [SPARK-30958][SQL] do not set default era for DateTimeFormatter
URL: https://github.com/apache/spark/pull/27707#discussion_r392012841
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala
 ##########
 @@ -62,10 +62,14 @@ class Iso8601TimestampFormatter(
       val parsed = formatter.parse(s)
       val parsedZoneId = parsed.query(TemporalQueries.zone())
       val timeZoneId = if (parsedZoneId == null) zoneId else parsedZoneId
-      val zonedDateTime = toZonedDateTime(parsed, timeZoneId)
+      // Parsed input might not have time related part. In that case, time component is set to
+      // zeros.
+      val parsedLocalTime = parsed.query(TemporalQueries.localTime)
+      val localTime = if (parsedLocalTime == null) LocalTime.MIDNIGHT else parsedLocalTime
+      val localDate = getLocalDate(s, parsed)
+      val zonedDateTime = ZonedDateTime.of(localDate, localTime, timeZoneId)
 
 Review comment:
   @cloud-fan, did we pull these codes out of `toZonedDateTime`? I thought we can just fix it in `toZonedDateTime`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org