You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/10/27 02:01:28 UTC
[kudu-CR] [consensus] relax memory ordering for ConsensusMetadata::on disk size
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25214
Change subject: [consensus] relax memory ordering for ConsensusMetadata::on_disk_size_
......................................................................
[consensus] relax memory ordering for ConsensusMetadata::on_disk_size_
The ConsensusMetadata::on_disk_size_ field is read for reporting
purposes: TabletReplica::OnDiskSize() uses it to compute total size
on disk consumed by a tablet replica, which is included in various
metrics and reported at embedded webserver's pages. So, it's read using
the memory_order_relaxed scheme, which does make sense. However, the
obvious asymmetry was there before this changelist: the on_disk_size_
field was updated using the memory_order_seq_cst scheme, which didn't
make sense.
Change-Id: I1caf244bab2ec750e976467725d3bf06109180d7
---
M src/kudu/consensus/consensus_meta.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/25214/1
--
To view, visit http://gerrit.cloudera.org:8080/25214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1caf244bab2ec750e976467725d3bf06109180d7
Gerrit-Change-Number: 25214
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [consensus] relax memory ordering for ConsensusMetadata::on disk size
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25214 )
Change subject: [consensus] relax memory ordering for ConsensusMetadata::on_disk_size_
......................................................................
Patch Set 1: Verified+1
RELEASE build config: unrelated test failure due to KUDU-3000
--
To view, visit http://gerrit.cloudera.org:8080/25214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1caf244bab2ec750e976467725d3bf06109180d7
Gerrit-Change-Number: 25214
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Oct 2026 03:19:37 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] relax memory ordering for ConsensusMetadata::on disk size
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/25214 )
Change subject: [consensus] relax memory ordering for ConsensusMetadata::on_disk_size_
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/25214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1caf244bab2ec750e976467725d3bf06109180d7
Gerrit-Change-Number: 25214
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Oct 2026 11:18:45 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] relax memory ordering for ConsensusMetadata::on disk size
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/25214 )
Change subject: [consensus] relax memory ordering for ConsensusMetadata::on_disk_size_
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/25214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1caf244bab2ec750e976467725d3bf06109180d7
Gerrit-Change-Number: 25214
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Oct 2026 10:24:56 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] relax memory ordering for ConsensusMetadata::on disk size
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [consensus] relax memory ordering for ConsensusMetadata::on_disk_size_
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/25214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1caf244bab2ec750e976467725d3bf06109180d7
Gerrit-Change-Number: 25214
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [consensus] relax memory ordering for ConsensusMetadata::on disk size
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25214 )
Change subject: [consensus] relax memory ordering for ConsensusMetadata::on_disk_size_
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/3165/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/25214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1caf244bab2ec750e976467725d3bf06109180d7
Gerrit-Change-Number: 25214
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Oct 2026 02:46:56 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] relax memory ordering for ConsensusMetadata::on disk size
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25214 )
Change subject: [consensus] relax memory ordering for ConsensusMetadata::on_disk_size_
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/3165/
--
To view, visit http://gerrit.cloudera.org:8080/25214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1caf244bab2ec750e976467725d3bf06109180d7
Gerrit-Change-Number: 25214
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 27 Oct 2026 02:01:35 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] relax memory ordering for ConsensusMetadata::on disk size
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25214 )
Change subject: [consensus] relax memory ordering for ConsensusMetadata::on_disk_size_
......................................................................
[consensus] relax memory ordering for ConsensusMetadata::on_disk_size_
The ConsensusMetadata::on_disk_size_ field is read for reporting
purposes: TabletReplica::OnDiskSize() uses it to compute total size
on disk consumed by a tablet replica, which is included in various
metrics and reported at embedded webserver's pages. So, it's read using
the memory_order_relaxed scheme, which does make sense. However, the
obvious asymmetry was there before this changelist: the on_disk_size_
field was updated using the memory_order_seq_cst scheme, which didn't
make sense.
Change-Id: I1caf244bab2ec750e976467725d3bf06109180d7
Reviewed-on: http://gerrit.cloudera.org:8080/25214
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M src/kudu/consensus/consensus_meta.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Verified
Zoltan Martonka: Looks good to me, approved
Marton Greber: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/25214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1caf244bab2ec750e976467725d3bf06109180d7
Gerrit-Change-Number: 25214
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>