You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "ByteYue (via GitHub)" <gi...@apache.org> on 2023/01/29 04:26:39 UTC
[GitHub] [doris] ByteYue opened a new pull request, #16185: [BugFix](sort) don't use 2 phase sort when countering agg table
ByteYue opened a new pull request, #16185:
URL: https://github.com/apache/doris/pull/16185
# Proposed changes
Issue Number: close #xxx
The former logic would try to do 2 phase sort optimization for all table type. The newly added `__DORIS_ROWID_COL__` column in #15642 doesn't support agg function which would result coredump.
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [x] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16185: [BugFix](sort) use correct agg function when using 2 phase sort for agg table
Posted by github-actions.
github-actions[bot] commented on PR #16185:
URL: https://github.com/apache/doris/pull/16185#issuecomment-1410171557
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on a diff in pull request #16185: [BugFix](sort) don't use 2 phase sort when countering agg table
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on code in PR #16185:
URL: https://github.com/apache/doris/pull/16185#discussion_r1090214262
##########
regression-test/suites/query_p0/sort/sort.groovy:
##########
@@ -23,4 +23,22 @@ suite("sort") {
qt_sort_string_single_column """ select * from ( select '汇总' as a union all select '2022-01-01' as a ) a order by 1 """
qt_sort_string_multiple_columns """ select * from ( select '汇总' as a,1 as b union all select '2022-01-01' as a,1 as b ) a order by 1,2 """
qt_sort_string_on_fe """ select '汇总' > '2022-01-01' """
+
+ sql """CREATE TABLE IF NOT EXISTS NO2PhaseSortWhenAggTable
Review Comment:
`2PhaseSortWhenAggTable` could be more correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16185: [BugFix](sort) don't use 2 phase sort when countering agg table
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16185:
URL: https://github.com/apache/doris/pull/16185#issuecomment-1407566801
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.42 seconds
load time: 487 seconds
storage size: 17122532887 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230129053307_clickbench_pr_86027.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16185: [BugFix](sort) don't use 2 phase sort when countering agg table
Posted by github-actions.
github-actions[bot] commented on PR #16185:
URL: https://github.com/apache/doris/pull/16185#issuecomment-1407998583
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #16185: [BugFix](sort) don't use 2 phase sort when countering agg table
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #16185:
URL: https://github.com/apache/doris/pull/16185#issuecomment-1407945139
we could modify __DORIS_ROWID_COL__ to `replace`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16185: [BugFix](sort) don't use 2 phase sort when countering agg table
Posted by github-actions.
github-actions[bot] commented on PR #16185:
URL: https://github.com/apache/doris/pull/16185#issuecomment-1407999498
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16185: [BugFix](sort) use correct agg function when using 2 phase sort for agg table
Posted by github-actions.
github-actions[bot] commented on PR #16185:
URL: https://github.com/apache/doris/pull/16185#issuecomment-1411372728
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16185: [BugFix](sort) use correct agg function when using 2 phase sort for agg table
Posted by github-actions.
github-actions[bot] commented on PR #16185:
URL: https://github.com/apache/doris/pull/16185#issuecomment-1410046886
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16185: [BugFix](sort) use correct agg function when using 2 phase sort for agg table
Posted by github-actions.
github-actions[bot] commented on PR #16185:
URL: https://github.com/apache/doris/pull/16185#issuecomment-1408252910
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16185: [BugFix](sort) use correct agg function when using 2 phase sort for agg table
Posted by github-actions.
github-actions[bot] commented on PR #16185:
URL: https://github.com/apache/doris/pull/16185#issuecomment-1408072397
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ByteYue commented on a diff in pull request #16185: [BugFix](sort) don't use 2 phase sort when countering agg table
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on code in PR #16185:
URL: https://github.com/apache/doris/pull/16185#discussion_r1090220314
##########
regression-test/suites/query_p0/sort/sort.groovy:
##########
@@ -23,4 +23,22 @@ suite("sort") {
qt_sort_string_single_column """ select * from ( select '汇总' as a union all select '2022-01-01' as a ) a order by 1 """
qt_sort_string_multiple_columns """ select * from ( select '汇总' as a,1 as b union all select '2022-01-01' as a,1 as b ) a order by 1,2 """
qt_sort_string_on_fe """ select '汇总' > '2022-01-01' """
+
+ sql """CREATE TABLE IF NOT EXISTS NO2PhaseSortWhenAggTable
Review Comment:
Oh, I'll change it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #16185: [BugFix](sort) use correct agg function when using 2 phase sort for agg table
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #16185:
URL: https://github.com/apache/doris/pull/16185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org