You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tiles.apache.org by ap...@apache.org on 2008/02/16 17:21:26 UTC

svn commit: r628345 - in /tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles: config/tiles-defs.xml definition/digester/TestDigesterDefinitionsReader.java

Author: apetrelli
Date: Sat Feb 16 08:21:25 2008
New Revision: 628345

URL: http://svn.apache.org/viewvc?rev=628345&view=rev
Log:
TILES-240
Added test to see if an empty <put-list-attribute> produces a ListAttribute (that appears to be true).

Modified:
    tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/config/tiles-defs.xml
    tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/definition/digester/TestDigesterDefinitionsReader.java

Modified: tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/config/tiles-defs.xml
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/config/tiles-defs.xml?rev=628345&r1=628344&r2=628345&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/config/tiles-defs.xml (original)
+++ tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/config/tiles-defs.xml Sat Feb 16 08:21:25 2008
@@ -138,5 +138,8 @@
   <put-attribute name="title" value="Test title" role="myrole" />
 </definition>
 
+<definition name="doc.listattribute.test" template="/layout/classicLayout.jsp">
+  <put-list-attribute name="items" />
+</definition>
 
 </tiles-definitions>

Modified: tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/definition/digester/TestDigesterDefinitionsReader.java
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/definition/digester/TestDigesterDefinitionsReader.java?rev=628345&r1=628344&r2=628345&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/definition/digester/TestDigesterDefinitionsReader.java (original)
+++ tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/definition/digester/TestDigesterDefinitionsReader.java Sat Feb 16 08:21:25 2008
@@ -24,6 +24,7 @@
 import java.io.InputStream;
 import java.net.URL;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import junit.framework.Test;
 import junit.framework.TestCase;
@@ -33,6 +34,7 @@
 import org.apache.commons.logging.LogFactory;
 import org.apache.tiles.Attribute;
 import org.apache.tiles.Definition;
+import org.apache.tiles.context.ListAttribute;
 import org.apache.tiles.definition.DefinitionsFactoryException;
 import org.apache.tiles.definition.DefinitionsReader;
 
@@ -108,6 +110,14 @@
             assertEquals("Role 'myrole' expected", attribute.getRole(),
                     "myrole");
 
+            def = definitions.get("doc.listattribute.test");
+            assertNotNull("Couldn't find doc.listattribute.test tile.", def);
+            attribute = def.getAttribute("items");
+            assertNotNull("Couldn't Find items attribute.", attribute);
+            assertTrue("The class of the attribute is not right",
+                    attribute instanceof ListAttribute);
+            assertTrue("The class of value of the attribute is not right",
+                    attribute.getValue() instanceof List);
         } catch (Exception e) {
             fail("Exception reading configuration." + e);
         }