You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/05/20 22:34:05 UTC
Review Request 70685: Removed the `TaskStatusUpdateIsTerminalState`
matcher.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70685/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Gilbert Song.
Repository: mesos
Description
-------
The `TaskStatusUpdateIsTerminalState` test matcher does not handle both
v0 and v1 status updates. Since introducing such a matcher in the
`v1::scheduler` namespace is inconsistent and it is not hard to use the
built-in `Truly` matcher to implement the same functionality, this
matcher is removed for now.
Diffs
-----
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 7f5bd8cd4c07b724fe2c49068bf327e5afe9ec41
src/tests/mesos.hpp e70e0e1bbebef41557f9bb1f26c379357fc74e2a
Diff: https://reviews.apache.org/r/70685/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70685: Removed the
`TaskStatusUpdateIsTerminalState` matcher.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70685/#review215407
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On May 21, 2019, 12:34 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70685/
> -----------------------------------------------------------
>
> (Updated May 21, 2019, 12:34 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `TaskStatusUpdateIsTerminalState` test matcher does not handle both
> v0 and v1 status updates. Since introducing such a matcher in the
> `v1::scheduler` namespace is inconsistent and it is not hard to use the
> built-in `Truly` matcher to implement the same functionality, this
> matcher is removed for now.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 7f5bd8cd4c07b724fe2c49068bf327e5afe9ec41
> src/tests/mesos.hpp e70e0e1bbebef41557f9bb1f26c379357fc74e2a
>
>
> Diff: https://reviews.apache.org/r/70685/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>