You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/11/27 07:22:41 UTC
Review Request 40760: Support OR in filterBy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40760/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1490
https://issues.apache.org/jira/browse/FALCON-1490
Repository: falcon-git
Description
-------
As of now only AND is supported in filterBy, it would be useful to have OR support too so that users can use filterBy accordingly.
Diffs
-----
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a
Diff: https://reviews.apache.org/r/40760/diff/
Testing
-------
Done.
Thanks,
Narayan Periwal
Re: Review Request 40760: Fixing the inconsistencies in the filterBy
Posted by Narayan Periwal <na...@inmobi.com>.
> On Nov. 27, 2015, 6:26 a.m., Ajay Yadava wrote:
> > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java, line 962
> > <https://reviews.apache.org/r/40760/diff/1/?file=1147813#file1147813line962>
> >
> > Can you please add a unit test for both the cases?
Yes, I will add it.
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40760/#review108194
-----------------------------------------------------------
On Nov. 27, 2015, 6:52 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40760/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 6:52 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1490
> https://issues.apache.org/jira/browse/FALCON-1490
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> For entity list and summary, the OR is inconsistent within the field CLUSTER and PIPELINES. Only the first value of these field is being considered for filterBy rather than considering the OR.
> for example, falcon entity -type process -list -filterBy PIPELINES:lda,PIPELINES:cob
> This will output the process with pipeline=lda. "PIPELINES:cob" is ignored.
> This inconsistency will be fixed as part of this jira.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a
>
> Diff: https://reviews.apache.org/r/40760/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 40760: Support OR in filterBy
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40760/#review108194
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 962)
<https://reviews.apache.org/r/40760/#comment167528>
Can you please add a unit test for both the cases?
- Ajay Yadava
On Nov. 27, 2015, 6:22 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40760/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 6:22 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1490
> https://issues.apache.org/jira/browse/FALCON-1490
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> As of now only AND is supported in filterBy, it would be useful to have OR support too so that users can use filterBy accordingly.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a
>
> Diff: https://reviews.apache.org/r/40760/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 40760: Fixing the inconsistencies in the filterBy
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40760/#review108370
-----------------------------------------------------------
Ship it!
Ship It!
- Balu Vellanki
On Nov. 27, 2015, 11:16 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40760/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 11:16 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1490
> https://issues.apache.org/jira/browse/FALCON-1490
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> For entity list and summary, the OR is inconsistent within the field CLUSTER and PIPELINES. Only the first value of these field is being considered for filterBy rather than considering the OR.
> for example, falcon entity -type process -list -filterBy PIPELINES:lda,PIPELINES:cob
> This will output the process with pipeline=lda. "PIPELINES:cob" is ignored.
> This inconsistency will be fixed as part of this jira.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a
> prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 5fabcf3
>
> Diff: https://reviews.apache.org/r/40760/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 40760: Fixing the inconsistencies in the filterBy
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40760/
-----------------------------------------------------------
(Updated Nov. 27, 2015, 11:16 a.m.)
Review request for Falcon.
Changes
-------
Added the required testcases for filterBy
Bugs: FALCON-1490
https://issues.apache.org/jira/browse/FALCON-1490
Repository: falcon-git
Description
-------
For entity list and summary, the OR is inconsistent within the field CLUSTER and PIPELINES. Only the first value of these field is being considered for filterBy rather than considering the OR.
for example, falcon entity -type process -list -filterBy PIPELINES:lda,PIPELINES:cob
This will output the process with pipeline=lda. "PIPELINES:cob" is ignored.
This inconsistency will be fixed as part of this jira.
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a
prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 5fabcf3
Diff: https://reviews.apache.org/r/40760/diff/
Testing
-------
Done.
Thanks,
Narayan Periwal
Re: Review Request 40760: Fixing the inconsistencies in the filterBy
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40760/
-----------------------------------------------------------
(Updated Nov. 27, 2015, 6:52 a.m.)
Review request for Falcon.
Summary (updated)
-----------------
Fixing the inconsistencies in the filterBy
Bugs: FALCON-1490
https://issues.apache.org/jira/browse/FALCON-1490
Repository: falcon-git
Description (updated)
-------
For entity list and summary, the OR is inconsistent within the field CLUSTER and PIPELINES. Only the first value of these field is being considered for filterBy rather than considering the OR.
for example, falcon entity -type process -list -filterBy PIPELINES:lda,PIPELINES:cob
This will output the process with pipeline=lda. "PIPELINES:cob" is ignored.
This inconsistency will be fixed as part of this jira.
Diffs
-----
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a
Diff: https://reviews.apache.org/r/40760/diff/
Testing
-------
Done.
Thanks,
Narayan Periwal