You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:38:24 UTC
[GitHub] [whimsy] clr-apache opened a new pull request #126: Update parts.js.rb
clr-apache opened a new pull request #126:
URL: https://github.com/apache/whimsy/pull/126
Remove "missing phone" from "incomplete ICLA"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [whimsy] sebbASF commented on pull request #126: Update parts.js.rb
Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #126:
URL: https://github.com/apache/whimsy/pull/126#issuecomment-944890293
It would help to know why this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [whimsy] sebbASF merged pull request #126: Update parts.js.rb
Posted by GitBox <gi...@apache.org>.
sebbASF merged pull request #126:
URL: https://github.com/apache/whimsy/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [whimsy] sebbASF commented on a change in pull request #126: Update parts.js.rb
Posted by GitBox <gi...@apache.org>.
sebbASF commented on a change in pull request #126:
URL: https://github.com/apache/whimsy/pull/126#discussion_r730400438
##########
File path: www/secretary/workbench/views/parts.js.rb
##########
@@ -163,13 +163,6 @@ def render
_input type: 'hidden', name: 'missing_email', value: @missing_email
spacer = "\u00A0"*4 # non-breaking space as UTF-8
- _label do
- _ spacer
- _input type: 'checkbox', checked: @missing_phone,
- onClick:-> {@missing_phone = !@missing_phone}
- _span ' missing phone number'
- end
-
_label do
Review comment:
These are not the only references to missing_phone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [whimsy] clr-apache commented on pull request #126: Update parts.js.rb
Posted by GitBox <gi...@apache.org>.
clr-apache commented on pull request #126:
URL: https://github.com/apache/whimsy/pull/126#issuecomment-945167453
> Other references to missing_phone need to be fixed
I've updated other references. Can you re-review? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [whimsy] clr-apache commented on pull request #126: Update parts.js.rb
Posted by GitBox <gi...@apache.org>.
clr-apache commented on pull request #126:
URL: https://github.com/apache/whimsy/pull/126#issuecomment-944958514
Thanks for taking a look.
We no longer ask for phone number; there is no place on the form for phone number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org