You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/08/07 22:06:59 UTC

[kudu-CR] catalog manager: cleanup status messages 

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3858

to review the following change.

Change subject: catalog manager: cleanup status messages
......................................................................

catalog manager: cleanup status messages

We were using the protobuf 'DebugString' method to fill out status messages.
DebugString adds newlines to the output, which isn't necessary for these short
statuses. Switching to 'ShortDebugString' removes the newlines.

Change-Id: I09e728e4f1e012ebd468d2244d18b31f1fb7c16b
---
M src/kudu/master/catalog_manager.cc
1 file changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/3858/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09e728e4f1e012ebd468d2244d18b31f1fb7c16b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] catalog manager: cleanup status messages

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: catalog manager: cleanup status messages
......................................................................


catalog manager: cleanup status messages

We were using the protobuf 'DebugString' method to fill out status messages.
DebugString adds newlines to the output, which isn't necessary for these short
statuses. Switching to 'ShortDebugString' removes the newlines.

Change-Id: I09e728e4f1e012ebd468d2244d18b31f1fb7c16b
Reviewed-on: http://gerrit.cloudera.org:8080/3858
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/master/catalog_manager.cc
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I09e728e4f1e012ebd468d2244d18b31f1fb7c16b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] catalog manager: cleanup status messages

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: catalog manager: cleanup status messages
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e728e4f1e012ebd468d2244d18b31f1fb7c16b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] catalog manager: cleanup status messages

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: catalog manager: cleanup status messages
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2736/

-- 
To view, visit http://gerrit.cloudera.org:8080/3858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e728e4f1e012ebd468d2244d18b31f1fb7c16b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No