You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/02/04 09:56:47 UTC

[GitHub] [lucene-solr] jpountz opened a new pull request #1237: SOLR-14238: Fix HdfsDirectory to no longer overwrite existing files.

jpountz opened a new pull request #1237: SOLR-14238: Fix HdfsDirectory to no longer overwrite existing files.
URL: https://github.com/apache/lucene-solr/pull/1237
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] jpountz merged pull request #1237: SOLR-14238: Fix HdfsDirectory to no longer overwrite existing files.

Posted by GitBox <gi...@apache.org>.
jpountz merged pull request #1237: SOLR-14238: Fix HdfsDirectory to no longer overwrite existing files.
URL: https://github.com/apache/lucene-solr/pull/1237
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] jpountz commented on issue #1237: SOLR-14238: Fix HdfsDirectory to no longer overwrite existing files.

Posted by GitBox <gi...@apache.org>.
jpountz commented on issue #1237: SOLR-14238: Fix HdfsDirectory to no longer overwrite existing files.
URL: https://github.com/apache/lucene-solr/pull/1237#issuecomment-581842008
 
 
   @risdenk Correct. I'd also like to add support for `createTempOutput` in a follow-up change. The lack of support for it in `HdfsDirectory` means Solr tests don't pass on my other pull request https://github.com/apache/lucene-solr/pull/1179, and one way to make it work would be to generate temporary file names until creating a file with this name doesn't throw a `FileAlreadyExistsException`, like we do in `FSDirectory`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] jpountz commented on issue #1237: SOLR-14238: Fix HdfsDirectory to no longer overwrite existing files.

Posted by GitBox <gi...@apache.org>.
jpountz commented on issue #1237: SOLR-14238: Fix HdfsDirectory to no longer overwrite existing files.
URL: https://github.com/apache/lucene-solr/pull/1237#issuecomment-582052471
 
 
   Thanks @risdenk !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org