You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/06/05 20:09:31 UTC
[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #209: refactor(extensions/nanoarrow_ipc): Reconfigure assembling arrays for better validation
paleolimbot opened a new pull request, #209:
URL: https://github.com/apache/arrow-nanoarrow/pull/209
Currently the decoder always assembles an `ArrowArray` and subsequently validates that array. That caused a problem when validating a union because the `ArrowArray` builder doesn't have a place to put custom type IDs. Also, this is every so slightly wasteful: the `ArrowArray` validation allocates an unnecessary `ArrowArrayView` and validates that. We already have an `ArrowArrayView` to help with the buffer shuffling, so this PR just swaps the direction: the first step is to create the `ArrowArrayView`; the second step is to populate the `ArrowArray` (if requested).
TODO: Finish the refactoring, actually try validating unions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #209: refactor(extensions/nanoarrow_ipc): Reconfigure assembling arrays for better validation
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #209:
URL: https://github.com/apache/arrow-nanoarrow/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] codecov-commenter commented on pull request #209: refactor(extensions/nanoarrow_ipc): Reconfigure assembling arrays for better validation
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #209:
URL: https://github.com/apache/arrow-nanoarrow/pull/209#issuecomment-1577765285
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#209](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2b28459) into [main](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/16905796359bd07eb0ea65f7b6b0fbd404494bee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1690579) will **increase** coverage by `0.06%`.
> The diff coverage is `94.66%`.
```diff
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 87.84% 87.90% +0.06%
==========================================
Files 60 60
Lines 9211 9242 +31
==========================================
+ Hits 8091 8124 +33
+ Misses 1120 1118 -2
```
| [Impacted Files](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [src/nanoarrow/nanoarrow.h](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL25hbm9hcnJvdy9uYW5vYXJyb3cuaA==) | `100.00% <ø> (ø)` | |
| [...anoarrow\_ipc/src/nanoarrow/nanoarrow\_ipc\_decoder.c](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXh0ZW5zaW9ucy9uYW5vYXJyb3dfaXBjL3NyYy9uYW5vYXJyb3cvbmFub2Fycm93X2lwY19kZWNvZGVyLmM=) | `81.63% <94.59%> (+1.03%)` | :arrow_up: |
| [src/nanoarrow/array.c](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL25hbm9hcnJvdy9hcnJheS5j) | `93.65% <100.00%> (ø)` | |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/209/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org