[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #7927: [Feature-5485] add job monitoring

[GitBox <gi...@apache.org>]

caishunfeng commented on a change in pull request #7927:
URL: https://github.com/apache/dolphinscheduler/pull/7927#discussion_r817316182



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskInstanceServiceImpl.java
##########
@@ -200,4 +205,28 @@ public Result queryTaskListPaging(User loginUser,
         }
         return result;
     }
+
+    @Override
+    public Result<Object> queryRankExecuteTime(User loginUser, long projectCode, Integer top, ExecutionStatus stateType, String startTime, String endTime) {
+        Result result = new Result();
+        Project project = projectMapper.queryByCode(projectCode);
+        //check user access for project
+        Map<String, Object> checkResult = projectService.checkProjectAndAuth(loginUser, project, projectCode);
+        Status status = (Status) checkResult.get(Constants.STATUS);
+        if (status != Status.SUCCESS) {
+            putMsg(result,status);
+            return result;
+        }
+
+        String orderBy = "";
+        if (driverClassName.contains("postgresql")) {

Review comment:
       Is there a unified sql implementation? Because DS have PgSQL、MySQL、H2 now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org