You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/07 17:00:50 UTC

[GitHub] [kafka] vlsi commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

vlsi commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r665553313



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##########
@@ -64,6 +66,7 @@ public ClientState() {
         previousStandbyTasks.taskIds(new TreeSet<>());
         previousActiveTasks.taskIds(new TreeSet<>());
 
+        clientTags = new HashMap<>();

Review comment:
       I guess it would be better to move the assignment to the field declaration to avoid duplication among constructors.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org