You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Gabriela Gibson <ga...@gmail.com> on 2013/02/28 12:31:05 UTC

[PATCH] htaccess file and permissions

[[[
Update web server configuration file and change file permissions to 
remove the executable bit.

* site/publish/.htaccess():
   remove "XBitHack On".
* site/*
   remove svn:executable property from all files, with the
   exception of 'download/download.cgi'.

Patch by: Gabriela Gibson <gabriela.gibson{_AT_}gmail.com>
Suggested by: danielsh
]]]



Re: [PATCH] htaccess file and permissions

Posted by "C. Michael Pilato" <cm...@collab.net>.
Perfect!  It ensures that a dev such as myself who isn't closely following
the related discussion threads has a hope of understanding why the change
was made.

On 02/28/2013 04:45 PM, Gabriela Gibson wrote:
> On 28/02/13 14:42, C. Michael Pilato wrote:
>> IMO, your log message should explain the reason for and value of such a
>> sweeping change.  The diff already tells us what you've done -- developers
>> coming a few years after us will want to know *why* it was done.
>>
> How about:
> [[[
> Update web server configuration file and change all the file
> permissions to remove the executable bit.
> 
> "AddOutputFilter INCLUDES .html" is provided by httpd.conf
> and this makes the "XBitHack On" setting unnecessary.  Similarly,
> the file permissions of the *.html files that are set to 'executable'
> are not necessary.
> 
> See: http://svn.haxx.se/dev/archive-2013-02/0274.shtml for the discussion.
> 
> * site/publish/.htaccess():
>   remove "XBitHack On".
> * site/*
>   remove svn:executable property from all files.
> 
> Patch by: Gabriela Gibson <gabriela.gibson{_AT_}gmail.com>
> Suggested by: danielsh
> ]]]
> 
> 


-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development


Re: [PATCH] htaccess file and permissions

Posted by "C. Michael Pilato" <cm...@collab.net>.
Perfect!  It ensures that a dev such as myself who isn't closely following
the related discussion threads has a hope of understanding why the change
was made.

On 02/28/2013 04:45 PM, Gabriela Gibson wrote:
> On 28/02/13 14:42, C. Michael Pilato wrote:
>> IMO, your log message should explain the reason for and value of such a
>> sweeping change.  The diff already tells us what you've done -- developers
>> coming a few years after us will want to know *why* it was done.
>>
> How about:
> [[[
> Update web server configuration file and change all the file
> permissions to remove the executable bit.
> 
> "AddOutputFilter INCLUDES .html" is provided by httpd.conf
> and this makes the "XBitHack On" setting unnecessary.  Similarly,
> the file permissions of the *.html files that are set to 'executable'
> are not necessary.
> 
> See: http://svn.haxx.se/dev/archive-2013-02/0274.shtml for the discussion.
> 
> * site/publish/.htaccess():
>   remove "XBitHack On".
> * site/*
>   remove svn:executable property from all files.
> 
> Patch by: Gabriela Gibson <gabriela.gibson{_AT_}gmail.com>
> Suggested by: danielsh
> ]]]
> 
> 


-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development


Re: [PATCH] htaccess file and permissions

Posted by Ben Reser <be...@reser.org>.
On Thu, Feb 28, 2013 at 8:13 PM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> Please provide the Message-ID, or a link to mail-archives.apache.org
> (haxx.se is operated by a third party, so we should try not to rely on
> its indefinite existence).

One thing to add here is to make sure you click on the link to get the
Permalink if you try to get a link to mail-archives.apache.org if you
don't you'll end up just linking to the archive and not a specific
mail.  If you've got a Message-ID on the end of your URL then you're
linking to a specific message properly.

Re: [PATCH] htaccess file and permissions

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Daniel Shahaf wrote on Fri, Mar 01, 2013 at 06:13:54 +0200:
> +1 to commit.  The web site will update within a few seconds after your
> commit, so please check then that it still works (and fix or revert if
> not).

BTW, you can check whether the web site has updated by retrieving 
http://subversion.apache.org/.revision

Re: [PATCH] htaccess file and permissions

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Gabriela Gibson wrote on Thu, Feb 28, 2013 at 21:45:10 +0000:
> On 28/02/13 14:42, C. Michael Pilato wrote:
>> IMO, your log message should explain the reason for and value of such a
>> sweeping change.  The diff already tells us what you've done -- developers
>> coming a few years after us will want to know *why* it was done.
>>
> How about:
> [[[
> Update web server configuration file and change all the file
> permissions to remove the executable bit.
>
> "AddOutputFilter INCLUDES .html" is provided by httpd.conf
> and this makes the "XBitHack On" setting unnecessary.  Similarly,
> the file permissions of the *.html files that are set to 'executable'
> are not necessary.
>
> See: http://svn.haxx.se/dev/archive-2013-02/0274.shtml for the discussion.
>

Please provide the Message-ID, or a link to mail-archives.apache.org
(haxx.se is operated by a third party, so we should try not to rely on
its indefinite existence).

> * site/publish/.htaccess():
>   remove "XBitHack On".
> * site/*
>   remove svn:executable property from all files.
>
> Patch by: Gabriela Gibson <gabriela.gibson{_AT_}gmail.com>

You should remove the "Patch by" line, and add an "Approved by" line
when you commit.

> Suggested by: danielsh
> ]]]
>
>

+1 to commit.  The web site will update within a few seconds after your
commit, so please check then that it still works (and fix or revert if
not).

Thanks,

Daniel

Re: [PATCH] htaccess file and permissions

Posted by Gabriela Gibson <ga...@gmail.com>.
On 28/02/13 14:42, C. Michael Pilato wrote:
> IMO, your log message should explain the reason for and value of such a
> sweeping change.  The diff already tells us what you've done -- developers
> coming a few years after us will want to know *why* it was done.
>
How about:
[[[
Update web server configuration file and change all the file
permissions to remove the executable bit.

"AddOutputFilter INCLUDES .html" is provided by httpd.conf
and this makes the "XBitHack On" setting unnecessary.  Similarly,
the file permissions of the *.html files that are set to 'executable'
are not necessary.

See: http://svn.haxx.se/dev/archive-2013-02/0274.shtml for the discussion.

* site/publish/.htaccess():
   remove "XBitHack On".
* site/*
   remove svn:executable property from all files.

Patch by: Gabriela Gibson <gabriela.gibson{_AT_}gmail.com>
Suggested by: danielsh
]]]



Re: [PATCH] htaccess file and permissions

Posted by "C. Michael Pilato" <cm...@collab.net>.
IMO, your log message should explain the reason for and value of such a
sweeping change.  The diff already tells us what you've done -- developers
coming a few years after us will want to know *why* it was done.

On 02/28/2013 06:31 AM, Gabriela Gibson wrote:
> [[[
> Update web server configuration file and change file permissions to remove
> the executable bit.
> 
> * site/publish/.htaccess():
>   remove "XBitHack On".
> * site/*
>   remove svn:executable property from all files, with the
>   exception of 'download/download.cgi'.
> 
> Patch by: Gabriela Gibson <gabriela.gibson{_AT_}gmail.com>
> Suggested by: danielsh
> ]]]
> 
> 


-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development