You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/04/17 15:56:14 UTC
[GitHub] [kylin] codecov-io commented on issue #612: KYLIN-3961 Optimize
TopNCounter's merge function to reduce TopNCounter's error size.
codecov-io commented on issue #612: KYLIN-3961 Optimize TopNCounter's merge function to reduce TopNCounter's error size.
URL: https://github.com/apache/kylin/pull/612#issuecomment-484150945
# [Codecov](https://codecov.io/gh/apache/kylin/pull/612?src=pr&el=h1) Report
> Merging [#612](https://codecov.io/gh/apache/kylin/pull/612?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/595c4e2112afeaea8c2881626959e37bbed50c84?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/kylin/pull/612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #612 +/- ##
============================================
- Coverage 25.29% 25.28% -0.01%
+ Complexity 5826 5825 -1
============================================
Files 1379 1379
Lines 81720 81712 -8
Branches 11444 11438 -6
============================================
- Hits 20667 20660 -7
- Misses 59039 59041 +2
+ Partials 2014 2011 -3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/612?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/kylin/measure/topn/TopNCounter.java](https://codecov.io/gh/apache/kylin/pull/612/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS90b3BuL1RvcE5Db3VudGVyLmphdmE=) | `82.41% <50%> (+6.65%)` | `23 <0> (ø)` | :arrow_down: |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/612/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/612/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `48.83% <0%> (-3.49%)` | `7% <0%> (ø)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/612/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/612?src=pr&el=footer). Last update [595c4e2...9bc938f](https://codecov.io/gh/apache/kylin/pull/612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services