You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "MFWhen (via GitHub)" <gi...@apache.org> on 2026/03/24 22:21:18 UTC
[PR] fix(DagCalendarTab): improve background color retrieval and loading o… [airflow]
MFWhen opened a new pull request, #64189:
URL: https://github.com/apache/airflow/pull/64189
…verlay handling
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "MFWhen (via GitHub)" <gi...@apache.org>.
MFWhen commented on code in PR #64189:
URL: https://github.com/apache/airflow/pull/64189#discussion_r3047105235
##########
dev/update_github_branch_config.py:
##########
Review Comment:
is it all good now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #64189:
URL: https://github.com/apache/airflow/pull/64189#discussion_r3047066313
##########
dev/update_github_branch_config.py:
##########
Review Comment:
The file mode was changed. Please run `git update-index --chmod=+x dev/update_github_branch_config.py`. The commits on this pull request should only show one file changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading o… [airflow]
Posted by "MFWhen (via GitHub)" <gi...@apache.org>.
MFWhen commented on code in PR #64189:
URL: https://github.com/apache/airflow/pull/64189#discussion_r2999807139
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts:
##########
@@ -115,16 +128,16 @@ export class DagCalendarTab extends BasePage {
const overlay = this.page.getByTestId("calendar-loading-overlay");
- if (await overlay.isVisible().catch(() => false)) {
- await overlay.waitFor({ state: "hidden", timeout: 120_000 });
+ try {
+ await overlay.waitFor({ state: "hidden", timeout: 10_000 });
Review Comment:
alright ill try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #64189:
URL: https://github.com/apache/airflow/pull/64189#discussion_r3047066313
##########
dev/update_github_branch_config.py:
##########
Review Comment:
The file mode was changed. Please run
```git update-index --chmod=+x dev/update_github_branch_config.py```
The commits on this pull request should only show one file changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #64189:
URL: https://github.com/apache/airflow/pull/64189#issuecomment-4201866685
### Backport failed to create: v3-2-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/24101822856'> Run details </a>
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-2-test</td>
<td><a href="https://github.com/apache/airflow/commit/a02fbaa00cc51bce42c4375ca65febbe5589d6b2"><img src='https://img.shields.io/badge/Commit-a02fbaa-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker a02fbaa v3-2-test
```
This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#how-to-backport-pr-with-cherry-picker-cli).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading o… [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on code in PR #64189:
URL: https://github.com/apache/airflow/pull/64189#discussion_r2994448305
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts:
##########
@@ -115,16 +128,16 @@ export class DagCalendarTab extends BasePage {
const overlay = this.page.getByTestId("calendar-loading-overlay");
- if (await overlay.isVisible().catch(() => false)) {
- await overlay.waitFor({ state: "hidden", timeout: 120_000 });
+ try {
+ await overlay.waitFor({ state: "hidden", timeout: 10_000 });
Review Comment:
Would it make sense to switch these to `expect().toBeVisible()` instead of `waitFor()`?
This could make the test more explicit and rely on Playwright’s built-in retry + assertion behavior.
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts:
##########
@@ -115,16 +128,16 @@ export class DagCalendarTab extends BasePage {
const overlay = this.page.getByTestId("calendar-loading-overlay");
- if (await overlay.isVisible().catch(() => false)) {
- await overlay.waitFor({ state: "hidden", timeout: 120_000 });
+ try {
+ await overlay.waitFor({ state: "hidden", timeout: 10_000 });
+ } catch {
+
}
await this.page.getByTestId("calendar-grid").waitFor({ state: "visible", timeout: 120_000 });
- await this.page.waitForFunction(() => {
- const cells = document.querySelectorAll('[data-testid="calendar-cell"]');
+ const cells = this.page.getByTestId("calendar-cell");
- return cells.length > 0;
- });
+ await cells.first().waitFor({ state: "attached", timeout: 120_000 });
Review Comment:
this too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #64189:
URL: https://github.com/apache/airflow/pull/64189#issuecomment-4160779919
yes, no need to include screenshots 👍
However, it looks like the CI is failing—could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "MFWhen (via GitHub)" <gi...@apache.org>.
MFWhen commented on code in PR #64189:
URL: https://github.com/apache/airflow/pull/64189#discussion_r3046708914
##########
dev/update_github_branch_config.py:
##########
Review Comment:
undo what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #64189:
URL: https://github.com/apache/airflow/pull/64189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #64189:
URL: https://github.com/apache/airflow/pull/64189#issuecomment-4148836491
If you make UI changes it is always very good for reviewers to have a "before" and "after" ascreenshot. Or a video showing the change. Can you add this to the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading o… [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #64189:
URL: https://github.com/apache/airflow/pull/64189#issuecomment-4121786244
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #64189:
URL: https://github.com/apache/airflow/pull/64189#issuecomment-4201860520
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "MFWhen (via GitHub)" <gi...@apache.org>.
MFWhen commented on PR #64189:
URL: https://github.com/apache/airflow/pull/64189#issuecomment-4157509573
> If you make UI changes it is always very good for reviewers to have a "before" and "after" ascreenshot. Or a video showing the change. Can you add this to the PR?
Hello,
There are no visual differences in the ui for this code. The change is limited to Playwright e2e test refactoring (locators/waits/assertions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #64189:
URL: https://github.com/apache/airflow/pull/64189#discussion_r3025333552
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts:
##########
@@ -50,9 +50,22 @@ export class DagCalendarTab extends BasePage {
for (let i = 0; i < count; i++) {
const cell = this.activeCells.nth(i);
- const bg = await cell.evaluate((el) => window.getComputedStyle(el).backgroundColor);
+ const computedStyle = await cell.getAttribute("style");
- colors.push(bg);
+ if (computedStyle) {
+ const bgColorMatch = computedStyle.match(/background-color\s*:\s*([^;]+)/);
+
+ if (bgColorMatch) {
+ colors.push(bgColorMatch[1].trim());
+ continue;
+ }
+ }
+
+ const dataColor = await cell.getAttribute("data-bg-color");
+
+ if (dataColor) {
+ colors.push(dataColor);
+ }
}
Review Comment:
`getActiveCellColors()` now reads `background-color` from the element's `style` attribute or a `data-bg-color` attribute. In the current UI implementation, `calendar-cell` backgrounds are applied via Chakra/emotion classes and (in daily mode) via child `<Box>` elements, and there is no `data-bg-color` attribute. This will typically result in `colors` being empty/shorter than the number of active cells. Consider reverting to `getComputedStyle(...)` (via `evaluate`) or updating the rendered calendar cells to expose the intended colors via explicit `data-*` attributes that the tests can read.
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts:
##########
@@ -112,22 +125,13 @@ export class DagCalendarTab extends BasePage {
}
private async waitForCalendarReady(): Promise<void> {
- await this.page.getByTestId("dag-calendar-root").waitFor({ state: "visible", timeout: 120_000 });
-
- await this.page.getByTestId("calendar-current-period").waitFor({ state: "visible", timeout: 120_000 });
-
- const overlay = this.page.getByTestId("calendar-loading-overlay");
-
- if (await overlay.isVisible().catch(() => false)) {
- await overlay.waitFor({ state: "hidden", timeout: 120_000 });
- }
+ await expect(this.page.getByTestId("dag-calendar-root")).toBeVisible({ timeout: 120_000 });
- await this.page.getByTestId("calendar-grid").waitFor({ state: "visible", timeout: 120_000 });
+ await expect(this.page.getByTestId("calendar-current-period")).toBeVisible({ timeout: 120_000 });
+ await expect(this.page.getByTestId("calendar-grid")).toBeVisible({ timeout: 120_000 });
Review Comment:
`waitForCalendarReady()` removed the loading overlay handling entirely. Since the overlay element is conditionally rendered, you can use a web-first assertion like `expect(overlay).toBeHidden(...)` (which passes when the element is absent) to ensure the calendar is actually ready for interactions, without the previous try/catch visibility check.
```suggestion
const overlay = this.page.getByTestId("calendar-loading-overlay");
await expect(overlay).toBeHidden({ timeout: 120_000 });
```
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts:
##########
@@ -88,7 +101,7 @@ export class DagCalendarTab extends BasePage {
public async navigateToCalendar(dagId: string) {
await expect(async () => {
await this.safeGoto(`/dags/${dagId}/calendar`);
- await this.page.getByTestId("dag-calendar-root").waitFor({ state: "visible", timeout: 5000 });
+ await expect(this.page.getByTestId("dag-calendar-root")).toBeVisible({ timeout: 5000 });
Review Comment:
The indentation inside `navigateToCalendar()`'s `expect(async () => { ... }).toPass(...)` block is inconsistent (the inner `await expect(...).toBeVisible(...)` line is not indented like similar patterns in other page objects, e.g. `BackfillPage.navigateToBackfillsTab` in `airflow-core/src/airflow/ui/tests/e2e/pages/BackfillPage.ts:378-381`). This will likely be reformatted by Prettier/ESLint; please run the formatter so the block matches the established style.
```suggestion
await expect(this.page.getByTestId("dag-calendar-root")).toBeVisible({ timeout: 5000 });
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #64189:
URL: https://github.com/apache/airflow/pull/64189#issuecomment-4441590462
Manual backport PR https://github.com/apache/airflow/pull/66860 up for review @choo121600 @bbovenzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading o… [airflow]
Posted by "MFWhen (via GitHub)" <gi...@apache.org>.
MFWhen commented on code in PR #64189:
URL: https://github.com/apache/airflow/pull/64189#discussion_r3001220562
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts:
##########
@@ -115,16 +128,16 @@ export class DagCalendarTab extends BasePage {
const overlay = this.page.getByTestId("calendar-loading-overlay");
- if (await overlay.isVisible().catch(() => false)) {
- await overlay.waitFor({ state: "hidden", timeout: 120_000 });
+ try {
+ await overlay.waitFor({ state: "hidden", timeout: 10_000 });
+ } catch {
+
}
await this.page.getByTestId("calendar-grid").waitFor({ state: "visible", timeout: 120_000 });
- await this.page.waitForFunction(() => {
- const cells = document.querySelectorAll('[data-testid="calendar-cell"]');
+ const cells = this.page.getByTestId("calendar-cell");
- return cells.length > 0;
- });
+ await cells.first().waitFor({ state: "attached", timeout: 120_000 });
Review Comment:
alright made those changes. please check them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #64189:
URL: https://github.com/apache/airflow/pull/64189#discussion_r3047108995
##########
dev/update_github_branch_config.py:
##########
Review Comment:
Yes. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #64189:
URL: https://github.com/apache/airflow/pull/64189#issuecomment-4169565248
@MFWhen This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
**Issues found:**
- :x: **Meaningful description**: The PR body contains no meaningful description of what the bug is, what the root cause is, or why these specific code changes fix it. The body is entirely the unfilled PR template — only the Gen-AI checkbox was touched; the actual description area above the '---' separator is completely blank.
- :x: **Unresolved merge conflict markers**: The file airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts contains unresolved Git merge conflict markers (<<<<<<< HEAD, =======, >>>>>>> 4bce21a34c62fcdb5b920d6c7535a6f9684cf079) inside the navigateToCalendar method. The file is broken and cannot be compiled or run as submitted.
- :x: **Gen-AI disclosure**: The author checked the Gen-AI box but left the tool name as the template placeholder '(please specify the tool below)' without naming the actual tool. The 'Generated-by' line is still commented out with '[Tool Name]' unfilled. The disclosure is incomplete per project guidelines.
- :warning: **Coherent changes**: dev/update_github_branch_config.py is included with a file-mode change (100755 → 100644) that is completely unrelated to any DagCalendarTab fix. Unrelated changes should be removed before submitting for review.
**What to do next:**
- The comment informs you what you need to do.
- Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
- There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates.
- Maintainers will then proceed with a normal review.
Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(DagCalendarTab): improve background color retrieval and loading overlay handling [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #64189:
URL: https://github.com/apache/airflow/pull/64189#discussion_r3046631162
##########
dev/update_github_branch_config.py:
##########
Review Comment:
This change is unrelated. Please undo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org