You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2020/08/01 01:52:08 UTC

[GitHub] [tika] PeterAlfredLee commented on a change in pull request #334: Tika-3141 : add empty environment variable handle

PeterAlfredLee commented on a change in pull request #334:
URL: https://github.com/apache/tika/pull/334#discussion_r463905876



##########
File path: tika-core/src/main/java/org/apache/tika/config/TikaConfig.java
##########
@@ -249,11 +249,11 @@ public TikaConfig(ClassLoader loader)
     public TikaConfig() throws TikaException, IOException {
 
         String config = System.getProperty("tika.config");
-        if (config == null) {
+        if (config == null || config.trim().equals("")) {

Review comment:
       It seems the `StringUtils` is part of `Apache Commons Lang`, which is not a dependecy of `tika core`. Should I add it in the `pom.xml`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org