[GitHub] [kafka] dajac commented on a change in pull request #11161: MINOR: Remove node from API versions cache on NetworkClient.close(nodeId)

[GitBox <gi...@apache.org>]

dajac commented on a change in pull request #11161:
URL: https://github.com/apache/kafka/pull/11161#discussion_r685277294



##########
File path: clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java
##########
@@ -198,6 +200,10 @@ public void testClose() {
         assertFalse(client.hasInFlightRequests(node.idString()));
         assertFalse(client.hasInFlightRequests());
         assertFalse(client.isReady(node, 0), "Connection should not be ready after close");
+        ApiVersions apiVersions  = TestUtils.fieldValue(client, NetworkClient.class, "apiVersions");

Review comment:
       nit: There is an extra space before `=` here and below.
   
   I am not a huge fan of using `TestUtils.fieldValue`. Did you consider making both attributes package private or something like this instead? `ApiVersions` is passed to the constructor of `NetworkClient` so we could access it this way as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org