You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/20 15:22:23 UTC
[GitHub] [couchdb-helm] arnediekmann opened a new pull request #21: Add
support for arbitrary sidecar containers
arnediekmann opened a new pull request #21: Add support for arbitrary sidecar containers
URL: https://github.com/apache/couchdb-helm/pull/21
#### What this PR does / why we need it:
We have the need in a few projects of ours to run a sidecar container to perform nightly backups. This could be used to add a sidecar container for Prometheus like discussed in #10 as well.
#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
- [ ] Chart Version bumped
- [ ] e2e tests pass
- [x] Variables are documented in the README.md
- [ ] Chart tgz added to /docs and index updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-helm] arnediekmann commented on issue #21: Add support for
arbitrary sidecar containers
Posted by GitBox <gi...@apache.org>.
arnediekmann commented on issue #21: Add support for arbitrary sidecar containers
URL: https://github.com/apache/couchdb-helm/pull/21#issuecomment-590334444
@willholley it's part of of d8a2194. My previous comment was a bit ambiguous :wink:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-helm] willholley commented on issue #21: Add support for
arbitrary sidecar containers
Posted by GitBox <gi...@apache.org>.
willholley commented on issue #21: Add support for arbitrary sidecar containers
URL: https://github.com/apache/couchdb-helm/pull/21#issuecomment-590333747
thanks @arnediekmann - looks good. Can you add the chart binary in the docs dir as well to match?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-helm] arnediekmann commented on issue #21: Add support for
arbitrary sidecar containers
Posted by GitBox <gi...@apache.org>.
arnediekmann commented on issue #21: Add support for arbitrary sidecar containers
URL: https://github.com/apache/couchdb-helm/pull/21#issuecomment-589718927
Hi @willholley, I'm trying to add a test configuration like you suggested, but kind `0.7.0` doesn't seem to work with `make test` anymore because `kind get kubeconfig-path` was deprecated (https://github.com/kubernetes-sigs/kind/commit/e258374de80352325dd830b8e5faf9270567d1a2). Should I try to fix that in a backwards-compatible manner or is it okay to require kind `>= 0.6.0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-helm] willholley commented on issue #21: Add support for
arbitrary sidecar containers
Posted by GitBox <gi...@apache.org>.
willholley commented on issue #21: Add support for arbitrary sidecar containers
URL: https://github.com/apache/couchdb-helm/pull/21#issuecomment-589251388
Thanks @arnediekmann. Can you bump the chart version and run `make publish` to generate the chart package?
It might also be worth adding a test configuration that injects a sidecar, which you can do by adding a new file e.g. `sidecar.yaml` with the complete `values.yaml` that you want to test in https://github.com/apache/couchdb-helm/tree/master/couchdb/ci.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-helm] arnediekmann commented on issue #21: Add support for
arbitrary sidecar containers
Posted by GitBox <gi...@apache.org>.
arnediekmann commented on issue #21: Add support for arbitrary sidecar containers
URL: https://github.com/apache/couchdb-helm/pull/21#issuecomment-590321085
@willholley thanks for #24 ... I had to tweak a few things but got it to work eventually as documented in the PR and could add a test set of values. I also bumped the chart version to 3.2.0 (Assuming this chart is adhering to semver).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-helm] willholley merged pull request #21: Add support for
arbitrary sidecar containers
Posted by GitBox <gi...@apache.org>.
willholley merged pull request #21: Add support for arbitrary sidecar containers
URL: https://github.com/apache/couchdb-helm/pull/21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-helm] willholley commented on issue #21: Add support for
arbitrary sidecar containers
Posted by GitBox <gi...@apache.org>.
willholley commented on issue #21: Add support for arbitrary sidecar containers
URL: https://github.com/apache/couchdb-helm/pull/21#issuecomment-589821761
@arnediekmann I submitted a PR at https://github.com/apache/couchdb-helm/pull/24 which updates Kind and Chart Testing. Does that help?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services