You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/30 10:01:39 UTC
[GitHub] [rocketmq] andsel opened a new issue #2853: Remove code duplication in CommitLog putMessage ayncPutMessage methods
andsel opened a new issue #2853:
URL: https://github.com/apache/rocketmq/issues/2853
The methods `asycPutMessage` and `putMessage` in class `CommitLog` shares a lot of code:
https://github.com/apache/rocketmq/blob/b4240d5cea8d001c21b9c0d73f5aa700fcd0d568/store/src/main/java/org/apache/rocketmq/store/CommitLog.java#L559-L662
https://github.com/apache/rocketmq/blob/b4240d5cea8d001c21b9c0d73f5aa700fcd0d568/store/src/main/java/org/apache/rocketmq/store/CommitLog.java#L788-L902
removing duplication simplify the code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky commented on issue #2853: Remove code duplication in CommitLog putMessage ayncPutMessage methods
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #2853:
URL: https://github.com/apache/rocketmq/issues/2853#issuecomment-833183670
@andsel would you like to submit a PR to polish it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] andsel commented on issue #2853: Remove code duplication in CommitLog putMessage ayncPutMessage methods
Posted by GitBox <gi...@apache.org>.
andsel commented on issue #2853:
URL: https://github.com/apache/rocketmq/issues/2853#issuecomment-833287678
@duhenglucky the PR #2854 solves this, missed to link it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org