You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by jjmeyer0 <gi...@git.apache.org> on 2017/07/05 21:49:34 UTC
[GitHub] metron pull request #633: METRON-1008: Updating travis to use trusty, moved ...
GitHub user jjmeyer0 opened a pull request:
https://github.com/apache/metron/pull/633
METRON-1008: Updating travis to use trusty, moved install to install …
…step, moved verify license to earlier step, and added .npm to cache.
## Contributor Comments
This is a continuation of [PR-632](https://github.com/apache/metron/pull/632) due to github not allowing a PR to be re-opened when a force push occurred.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jjmeyer0/incubator-metron METRON-1008
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/633.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #633
----
commit eb3abe1ae2eb5ff89a7e2bcb183d0bdf54f021b8
Author: JJ <jj...@gmail.com>
Date: 2017-06-29T22:43:58Z
METRON-1008: Updating travis to use trusty, moved install to install step, moved verify license to earlier step, and added .npm to cache.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron pull request #633: METRON-1008: Updating travis to use trusty, moved ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/633
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron issue #633: METRON-1008: Updating travis to use trusty, moved install...
Posted by jjmeyer0 <gi...@git.apache.org>.
Github user jjmeyer0 commented on the issue:
https://github.com/apache/metron/pull/633
Quote from @justinleet
> I'd be inclined towards avoiding splitting the build if we were only getting a couple minutes out of it. I'm a little worried about being able to get three slots on the occasionally stretched Apache setup. Integration tests and building are the long poles in the tent, so splitting out the other tests doesn't really save us much time here, unfortunately.
I agree, I have reverted this.
Quote from @ottobackwards
> I'm going to be honest. Now that we have the builds kind of working again, I'm a little hesitant to change them for anything but an absolute certainty of a return, that we completely understand.
>
> I think the travis build strategy should be a longer living branch maybe.
I reverted the multiple env changes, as I agree, it's not worth the small chunk of time that was shaved off. However, I think the rest of these changes can be helpful for the following reasons:
* moving the license verification to an earlier step can help the build fail fast. Forgetting to update the dependency file can be a common mistake. Failing earlier might save time and travis resources.
* I believe moving to trusty was recommended by travis-ci
* using travis' install step for the `mvn install`. No benefit that I know of. I just believe `mvn install` should happen here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron issue #633: METRON-1008: Updating travis to use trusty, moved install...
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/633
@ottobackwards Do you have any objections to the current state of the PR? At this point, I think this is a pretty focused, incremental change. I'm +1 on it, but I want to make sure you have a chance to chime in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron issue #633: METRON-1008: Updating travis to use trusty, moved install...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/633
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---