You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/23 22:20:02 UTC
[GitHub] [superset] graceguo-supercat opened a new pull request #16413: fix: setupPlugin in chart list page
graceguo-supercat opened a new pull request #16413:
URL: https://github.com/apache/superset/pull/16413
### SUMMARY
This PR is to fix issue found after #16285. See comment: https://github.com/apache/superset/pull/16285#issuecomment-902223125, the viz_type dropdown list became empty.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**after**:
<img width="1280" alt="Screen Shot 2021-08-23 at 3 19 23 PM" src="https://user-images.githubusercontent.com/27990562/130526692-9ee59917-7713-4b2b-9790-6e5997ed916c.png">
### TESTING INSTRUCTIONS
CI and manual test.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #16285
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16413: fix: setupPlugin in chart list page
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16413:
URL: https://github.com/apache/superset/pull/16413#issuecomment-904231606
@ktmud and @villebro, currently CI failed because of this error:
```
2021-08-24T00:39:47.9629614Z FAIL src/views/CRUD/chart/ChartList.test.jsx
2021-08-24T00:39:47.9630991Z ● Test suite failed to run
2021-08-24T00:39:47.9631426Z
2021-08-24T00:39:47.9637059Z Cannot find module 'file-loader!./countries/austria.geojson' from 'node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js'
2021-08-24T00:39:47.9638023Z
2021-08-24T00:39:47.9638460Z Require stack:
2021-08-24T00:39:47.9639808Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js
2021-08-24T00:39:47.9644421Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/controlPanel.js
2021-08-24T00:39:47.9647421Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/index.js
2021-08-24T00:39:47.9648478Z src/visualizations/presets/MainPreset.js
2021-08-24T00:39:47.9649144Z src/setup/setupPlugins.ts
2021-08-24T00:39:47.9650878Z src/views/CRUD/chart/ChartList.tsx
2021-08-24T00:39:47.9652831Z src/views/CRUD/chart/ChartList.test.jsx
2021-08-24T00:39:47.9653304Z
2021-08-24T00:39:47.9656539Z at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
2021-08-24T00:39:47.9661373Z at Object.<anonymous> (node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js:6:39)
2021-08-24T00:39:47.9662736Z
2021-08-24T00:39:47.9665935Z
2021-08-24T00:39:47.9673061Z Test Suites: 1 failed, 2 skipped, 337 passed, 338 of 340 total
```
is something wrong with country-map plugin? Or maybe i need to upgrade to a newer version? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat merged pull request #16413: fix: setupPlugin in chart list page
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #16413:
URL: https://github.com/apache/superset/pull/16413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16413: fix: setupPlugin in chart list page
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16413:
URL: https://github.com/apache/superset/pull/16413#issuecomment-904231606
@ktmud CI failed because of this error:
```
2021-08-24T00:39:47.9629614Z FAIL src/views/CRUD/chart/ChartList.test.jsx
2021-08-24T00:39:47.9630991Z ● Test suite failed to run
2021-08-24T00:39:47.9631426Z
2021-08-24T00:39:47.9637059Z Cannot find module '**file-loader!./countries/austria.geojson**' from 'node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js'
2021-08-24T00:39:47.9638023Z
2021-08-24T00:39:47.9638460Z Require stack:
2021-08-24T00:39:47.9639808Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js
2021-08-24T00:39:47.9644421Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/controlPanel.js
2021-08-24T00:39:47.9647421Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/index.js
2021-08-24T00:39:47.9648478Z src/visualizations/presets/MainPreset.js
2021-08-24T00:39:47.9649144Z src/setup/setupPlugins.ts
2021-08-24T00:39:47.9650878Z src/views/CRUD/chart/ChartList.tsx
2021-08-24T00:39:47.9652831Z src/views/CRUD/chart/ChartList.test.jsx
2021-08-24T00:39:47.9653304Z
2021-08-24T00:39:47.9656539Z at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
2021-08-24T00:39:47.9661373Z at Object.<anonymous> (node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js:6:39)
2021-08-24T00:39:47.9662736Z
2021-08-24T00:39:47.9665935Z
2021-08-24T00:39:47.9673061Z Test Suites: 1 failed, 2 skipped, 337 passed, 338 of 340 total
```
is something wrong with country-map plugin? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16413: fix: setupPlugin in chart list page
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16413:
URL: https://github.com/apache/superset/pull/16413#issuecomment-904231606
@ktmud CI failed because of this error:
```
2021-08-24T00:39:47.9629614Z FAIL src/views/CRUD/chart/ChartList.test.jsx
2021-08-24T00:39:47.9630991Z ● Test suite failed to run
2021-08-24T00:39:47.9631426Z
2021-08-24T00:39:47.9637059Z Cannot find module 'file-loader!./countries/austria.geojson' from 'node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js'
2021-08-24T00:39:47.9638023Z
2021-08-24T00:39:47.9638460Z Require stack:
2021-08-24T00:39:47.9639808Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js
2021-08-24T00:39:47.9644421Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/controlPanel.js
2021-08-24T00:39:47.9647421Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/index.js
2021-08-24T00:39:47.9648478Z src/visualizations/presets/MainPreset.js
2021-08-24T00:39:47.9649144Z src/setup/setupPlugins.ts
2021-08-24T00:39:47.9650878Z src/views/CRUD/chart/ChartList.tsx
2021-08-24T00:39:47.9652831Z src/views/CRUD/chart/ChartList.test.jsx
2021-08-24T00:39:47.9653304Z
2021-08-24T00:39:47.9656539Z at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
2021-08-24T00:39:47.9661373Z at Object.<anonymous> (node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js:6:39)
2021-08-24T00:39:47.9662736Z
2021-08-24T00:39:47.9665935Z
2021-08-24T00:39:47.9673061Z Test Suites: 1 failed, 2 skipped, 337 passed, 338 of 340 total
```
is something wrong with country-map plugin? Or maybe i need to upgrade to a newer version? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16413: fix: setupPlugin in chart list page
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16413:
URL: https://github.com/apache/superset/pull/16413#issuecomment-904231606
@ktmud CI failed because of this error:
```
2021-08-24T00:39:47.9629614Z FAIL src/views/CRUD/chart/ChartList.test.jsx
2021-08-24T00:39:47.9630991Z ● Test suite failed to run
2021-08-24T00:39:47.9631426Z
2021-08-24T00:39:47.9637059Z Cannot find module 'file-loader!./countries/austria.geojson' from 'node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js'
2021-08-24T00:39:47.9638023Z
2021-08-24T00:39:47.9638460Z Require stack:
2021-08-24T00:39:47.9639808Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js
2021-08-24T00:39:47.9644421Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/controlPanel.js
2021-08-24T00:39:47.9647421Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/index.js
2021-08-24T00:39:47.9648478Z src/visualizations/presets/MainPreset.js
2021-08-24T00:39:47.9649144Z src/setup/setupPlugins.ts
2021-08-24T00:39:47.9650878Z src/views/CRUD/chart/ChartList.tsx
2021-08-24T00:39:47.9652831Z src/views/CRUD/chart/ChartList.test.jsx
2021-08-24T00:39:47.9653304Z
2021-08-24T00:39:47.9656539Z at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
2021-08-24T00:39:47.9661373Z at Object.<anonymous> (node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js:6:39)
2021-08-24T00:39:47.9662736Z
2021-08-24T00:39:47.9665935Z
2021-08-24T00:39:47.9673061Z Test Suites: 1 failed, 2 skipped, 337 passed, 338 of 340 total
```
is something wrong with country-map plugin? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16413: fix: setupPlugin in chart list page
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16413:
URL: https://github.com/apache/superset/pull/16413#issuecomment-904231606
@ktmud CI failed because of this error:
```
2021-08-24T00:39:47.9629614Z FAIL src/views/CRUD/chart/ChartList.test.jsx
2021-08-24T00:39:47.9630991Z ● Test suite failed to run
2021-08-24T00:39:47.9631426Z
2021-08-24T00:39:47.9637059Z Cannot find module 'file-loader!./countries/austria.geojson' from 'node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js'
2021-08-24T00:39:47.9638023Z
2021-08-24T00:39:47.9638460Z Require stack:
2021-08-24T00:39:47.9639808Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js
2021-08-24T00:39:47.9644421Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/controlPanel.js
2021-08-24T00:39:47.9647421Z node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/index.js
2021-08-24T00:39:47.9648478Z src/visualizations/presets/MainPreset.js
2021-08-24T00:39:47.9649144Z src/setup/setupPlugins.ts
2021-08-24T00:39:47.9650878Z src/views/CRUD/chart/ChartList.tsx
2021-08-24T00:39:47.9652831Z src/views/CRUD/chart/ChartList.test.jsx
2021-08-24T00:39:47.9653304Z
2021-08-24T00:39:47.9656539Z at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
2021-08-24T00:39:47.9661373Z at Object.<anonymous> (node_modules/@superset-ui/legacy-plugin-chart-country-map/lib/countries.js:6:39)
2021-08-24T00:39:47.9662736Z
2021-08-24T00:39:47.9665935Z
2021-08-24T00:39:47.9673061Z Test Suites: 1 failed, 2 skipped, 337 passed, 338 of 340 total
```
is something wrong with country-map plugin? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org