[GitHub] [superset] ktmud commented on a change in pull request #13374: chore: convert chartReducer to TypeScript

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #13374:
URL: https://github.com/apache/superset/pull/13374#discussion_r584341845



##########
File path: superset-frontend/src/chart/chartReducer.ts
##########
@@ -134,7 +143,7 @@ export default function chartReducer(charts = {}, action) {
       }
       const annotationQuery = {
         ...state.annotationQuery,
-        [action.annotation.name]: action.queryRequest,
+        [action.annotation.name]: action.queryController,

Review comment:
       Bycatch by TypeScript: it seems the `ANNOTATION_QUERY_STARTED` is supposed to cancel previous annotation queries, but it used the wrong action prop. The source of the action is here:
   
   https://github.com/apache/superset/blob/6731cd0be6852c890a5e856e79470d08eb760437/superset-frontend/src/chart/chartAction.js#L97




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org