You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/01/25 18:15:04 UTC
Review Request 17353: Add a stat that tracks the number of threads waiting
for the storage lock.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17353/
-----------------------------------------------------------
Review request for Aurora and Joe Smith.
Repository: aurora
Description
-------
Add a stat that tracks the number of threads waiting for the storage lock.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 7a4d9aa1cf5657ffcbf69f6d6bfa0f39a21e2f5c
src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java eb6f9569e089858e27c2b8db15ebb66b5c6b61e7
Diff: https://reviews.apache.org/r/17353/diff/
Testing
-------
./gradlew build
Thanks,
Bill Farner
Re: Review Request 17353: Add a stat that tracks the number of threads
waiting for the storage lock.
Posted by Joe Smith <ya...@gmail.com>.
> On Jan. 25, 2014, 10:58 a.m., Joe Smith wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java, line 116
> > <https://reviews.apache.org/r/17353/diff/1/?file=450927#file450927line116>
> >
> > potentially naive thought- might it be interesting to also have a way to look at getQueuedThreads, or is that already in /threads?
>
> Bill Farner wrote:
> Close, /contention will show this information.
aha, that's what I should've looked at, thanks!
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17353/#review32784
-----------------------------------------------------------
On Jan. 25, 2014, 9:15 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17353/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2014, 9:15 a.m.)
>
>
> Review request for Aurora and Joe Smith.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a stat that tracks the number of threads waiting for the storage lock.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 7a4d9aa1cf5657ffcbf69f6d6bfa0f39a21e2f5c
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java eb6f9569e089858e27c2b8db15ebb66b5c6b61e7
>
> Diff: https://reviews.apache.org/r/17353/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17353: Add a stat that tracks the number of threads
waiting for the storage lock.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 25, 2014, 6:58 p.m., Joe Smith wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java, line 116
> > <https://reviews.apache.org/r/17353/diff/1/?file=450927#file450927line116>
> >
> > potentially naive thought- might it be interesting to also have a way to look at getQueuedThreads, or is that already in /threads?
Close, /contention will show this information.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17353/#review32784
-----------------------------------------------------------
On Jan. 25, 2014, 5:15 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17353/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2014, 5:15 p.m.)
>
>
> Review request for Aurora and Joe Smith.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a stat that tracks the number of threads waiting for the storage lock.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 7a4d9aa1cf5657ffcbf69f6d6bfa0f39a21e2f5c
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java eb6f9569e089858e27c2b8db15ebb66b5c6b61e7
>
> Diff: https://reviews.apache.org/r/17353/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17353: Add a stat that tracks the number of threads
waiting for the storage lock.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17353/#review32784
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java
<https://reviews.apache.org/r/17353/#comment61753>
potentially naive thought- might it be interesting to also have a way to look at getQueuedThreads, or is that already in /threads?
- Joe Smith
On Jan. 25, 2014, 9:15 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17353/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2014, 9:15 a.m.)
>
>
> Review request for Aurora and Joe Smith.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a stat that tracks the number of threads waiting for the storage lock.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 7a4d9aa1cf5657ffcbf69f6d6bfa0f39a21e2f5c
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java eb6f9569e089858e27c2b8db15ebb66b5c6b61e7
>
> Diff: https://reviews.apache.org/r/17353/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>