You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2009/03/31 12:41:54 UTC
[jira] Created: (CASSANDRA-29) Change value to binary from string
Change value to binary from string
----------------------------------
Key: CASSANDRA-29
URL: https://issues.apache.org/jira/browse/CASSANDRA-29
Project: Cassandra
Issue Type: Improvement
Reporter: Johan Oskarsson
In the thrift interface the value is of type string but internally in Cassandra it is handled as a byte array. Exposing the value as thrift type binary would avoid conversions and charset issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-29) Change value to binary from string
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated CASSANDRA-29:
-------------------------------------
Attachment: CASSANDRA-29.patch
Changes the interface, replaces the thrift generated files with new versions, modifies the server and various bits of code that calls the interface
> Change value to binary from string
> ----------------------------------
>
> Key: CASSANDRA-29
> URL: https://issues.apache.org/jira/browse/CASSANDRA-29
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Attachments: CASSANDRA-29.patch
>
>
> In the thrift interface the value is of type string but internally in Cassandra it is handled as a byte array. Exposing the value as thrift type binary would avoid conversions and charset issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-29) Change value to binary from string
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-29:
------------------------------------
Fix Version/s: 0.3
> Change value to binary from string
> ----------------------------------
>
> Key: CASSANDRA-29
> URL: https://issues.apache.org/jira/browse/CASSANDRA-29
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Fix For: 0.3
>
> Attachments: CASSANDRA-29.patch
>
>
> In the thrift interface the value is of type string but internally in Cassandra it is handled as a byte array. Exposing the value as thrift type binary would avoid conversions and charset issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-29) Change value to binary from string
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694158#action_12694158 ]
Jonathan Ellis commented on CASSANDRA-29:
-----------------------------------------
Sure, but if they decide that `string` really means `binary` then you might as well just drop the binary keyword.
> Change value to binary from string
> ----------------------------------
>
> Key: CASSANDRA-29
> URL: https://issues.apache.org/jira/browse/CASSANDRA-29
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Attachments: CASSANDRA-29.patch
>
>
> In the thrift interface the value is of type string but internally in Cassandra it is handled as a byte array. Exposing the value as thrift type binary would avoid conversions and charset issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-29) Change value to binary from string
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694152#action_12694152 ]
Johan Oskarsson commented on CASSANDRA-29:
------------------------------------------
My interpretation of that discussion isn't that they will remove the binary keyword, it is still a big help in Java
> Change value to binary from string
> ----------------------------------
>
> Key: CASSANDRA-29
> URL: https://issues.apache.org/jira/browse/CASSANDRA-29
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Attachments: CASSANDRA-29.patch
>
>
> In the thrift interface the value is of type string but internally in Cassandra it is handled as a byte array. Exposing the value as thrift type binary would avoid conversions and charset issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-29) Change value to binary from string
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694088#action_12694088 ]
Jonathan Ellis commented on CASSANDRA-29:
-----------------------------------------
Johan, I agree that binary data works better.
But I'm not sure if binary is going to be a data type in thrift moving forward; see the comments to https://issues.apache.org/jira/browse/THRIFT-395 (start where dreiss jumps in).
> Change value to binary from string
> ----------------------------------
>
> Key: CASSANDRA-29
> URL: https://issues.apache.org/jira/browse/CASSANDRA-29
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Attachments: CASSANDRA-29.patch
>
>
> In the thrift interface the value is of type string but internally in Cassandra it is handled as a byte array. Exposing the value as thrift type binary would avoid conversions and charset issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-29) Change value to binary from string
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-29:
---------------------------------------
Assignee: Jonathan Ellis
> Change value to binary from string
> ----------------------------------
>
> Key: CASSANDRA-29
> URL: https://issues.apache.org/jira/browse/CASSANDRA-29
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: CASSANDRA-29.patch
>
>
> In the thrift interface the value is of type string but internally in Cassandra it is handled as a byte array. Exposing the value as thrift type binary would avoid conversions and charset issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-29) Change value to binary from string
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694597#action_12694597 ]
Jonathan Ellis commented on CASSANDRA-29:
-----------------------------------------
Looks like binary is going to stay.
Avinash is working in the Service and StorageProxy area so let's wait for that commit to avoid causing him conflicts.
> Change value to binary from string
> ----------------------------------
>
> Key: CASSANDRA-29
> URL: https://issues.apache.org/jira/browse/CASSANDRA-29
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Attachments: CASSANDRA-29.patch
>
>
> In the thrift interface the value is of type string but internally in Cassandra it is handled as a byte array. Exposing the value as thrift type binary would avoid conversions and charset issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-29) Change value to binary from string
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700852#action_12700852 ]
Jonathan Ellis commented on CASSANDRA-29:
-----------------------------------------
For the record, the old code was potentially buggy because it assumed any string passed could be decoded as UTF-8. This is the case when the client is also Java code but not for other languages such as Python or C++. (Thrift is not consistent in how it treats strings, but it is always consistent with binary.)
> Change value to binary from string
> ----------------------------------
>
> Key: CASSANDRA-29
> URL: https://issues.apache.org/jira/browse/CASSANDRA-29
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 29-v2.patch, CASSANDRA-29.patch
>
>
> In the thrift interface the value is of type string but internally in Cassandra it is handled as a byte array. Exposing the value as thrift type binary would avoid conversions and charset issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-29) Change value to binary from string
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-29:
------------------------------------
Attachment: 29-v2.patch
looks good. rebased for changes in 33 and others.
> Change value to binary from string
> ----------------------------------
>
> Key: CASSANDRA-29
> URL: https://issues.apache.org/jira/browse/CASSANDRA-29
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 29-v2.patch, CASSANDRA-29.patch
>
>
> In the thrift interface the value is of type string but internally in Cassandra it is handled as a byte array. Exposing the value as thrift type binary would avoid conversions and charset issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.