You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/05 16:53:25 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #40:
Format all shell scripts in tools folder
xiaoxiang781216 opened a new pull request #40: Format all shell scripts in tools folder
URL: https://github.com/apache/incubator-nuttx/pull/40
Change-Id: Ieef2eb93d56c03972b4dc63a1c55aabf1fb0d169
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #40: Format all
shell scripts in tools folder
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #40: Format all shell scripts in tools folder
URL: https://github.com/apache/incubator-nuttx/pull/40
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #40: Format
all shell scripts in tools folder
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #40: Format all shell scripts in tools folder
URL: https://github.com/apache/incubator-nuttx/pull/40#issuecomment-570938662
> If there is a coding standard for shell scripts, we should document it.
> Or was this done using a tool? If a tools was used, we should document the tool.
The script has the different style:
1.Some use tab, other use space for indent
2.Some indent use two spaces, other use three/four spaces
My change unify all to 2 spaces like C style.
It's better to follow the C style with the addition for the special syntax constructure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #40: Format all
shell scripts in tools folder
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #40: Format all shell scripts in tools folder
URL: https://github.com/apache/incubator-nuttx/pull/40#issuecomment-570928984
If there is a coding standard for shell scripts, we should document it.
Or was this done using a tool? If a tools was used, we should document the tool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services