You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/09 13:29:42 UTC

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1519: ZOOKEEPER-3979: Clean up/robustify audit logs

eolivelli commented on a change in pull request #1519:
URL: https://github.com/apache/zookeeper/pull/1519#discussion_r519814562



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/DigestAuthenticationProvider.java
##########
@@ -31,13 +31,26 @@
 
     private static final Logger LOG = LoggerFactory.getLogger(DigestAuthenticationProvider.class);
 
+    private static final String DIGEST_AUTH_ENABLED = "zookeeper.DigestAuthenticationProvider.enabled";
+
     /** specify a command line property with key of
      * "zookeeper.DigestAuthenticationProvider.superDigest"
      * and value of "super:&lt;base64encoded(SHA1(password))&gt;" to enable
      * super user access (i.e. acls disabled)
      */
     private static final String superDigest = System.getProperty("zookeeper.DigestAuthenticationProvider.superDigest");
 
+    private static final boolean enabled;

Review comment:
       there won't be an easy way to turn in off/on during tests.
   do we need a static variable ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org