[GitHub] dgrove-oss commented on issue #4082: Rename prewarmed containers

[GitBox <gi...@apache.org>]

dgrove-oss commented on issue #4082: Rename prewarmed containers
URL: https://github.com/apache/incubator-openwhisk/pull/4082#issuecomment-435416839
 
 
   Stepping back, the motivation behind this PR is that if we create an action container via a cold start, the container name will contain the name of the function.  If we used a pre-warmed container, then the container name is stuck containing just "prewarm" and does not contain the name of the function.  It does not seem unreasonable to support an invariant that there is some external meta-data on the action container that indicates the name of the function that is being served by the container.   In the case of raw DockerContainerFactory, the "metadata" being used here is the container name.  In the case of KubernetesContainerFactory, we would use a label on the pod and not rely on the pod name.
   
   Its not really about telling prewarm from warm, but about being able to externally  map from containers to the namespace/function they are executing. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services