You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Mark Struberg <st...@yahoo.de> on 2012/09/12 20:03:36 UTC
Fw: [DISCUSS] release OWB-1.1.6 end of this week?
2nd try as my previous got eaten by the spam filter :/
----- Forwarded Message -----
>From: Mark Struberg <st...@yahoo.de>
>To: openwebbeans-dev <de...@openwebbeans.apache.org>
>Sent: Wednesday, September 12, 2012 7:49 PM
>Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>
>
>Hi folks!
>
>I would like to start with a hot-fix release of OWB (version 1.1.6) end of this week.
>Thomas, is this an ok timeframe in which you can fix the issues you needed for your production?
>
>LIeGrue,
>strub
>
>
>
>
>
Re: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Thomas Andraschko <zo...@gmail.com>.
Hi,
i will commit today :)
Regards,
Thomas
2012/9/15 Mark Struberg <st...@yahoo.de>
> Hi David!
>
> I can roll the release tonight or tomorrow morning.
> Udo still likes to get a few things done afaik. UnitTests and stuff...
>
>
> Thomas, did you commit all your changes which you have Jiras created for?
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
> > From: David Blevins <da...@gmail.com>
> > To: dev@openwebbeans.apache.org; Mark Struberg <st...@yahoo.de>
> > Cc:
> > Sent: Saturday, September 15, 2012 10:56 AM
> > Subject: Re: [DISCUSS] release OWB-1.1.6 end of this week?
> >
> >G ot the ASM support finished. OWB-701 officially closed.
> >
> > We still use Javassist by default, but we have the ability to use ASM.
> >
> > Mark, do you need help with the release? (I know you have a *very* busy
> week
> > coming up :)
> >
> >
> > -David
> >
> > On Sep 12, 2012, at 11:03 AM, Mark Struberg wrote:
> >
> >> 2nd try as my previous got eaten by the spam filter :/
> >>
> >>
> >>
> >>
> >>
> >> ----- Forwarded Message -----
> >>> From: Mark Struberg <st...@yahoo.de>
> >>> To: openwebbeans-dev <de...@openwebbeans.apache.org>
> >>> Sent: Wednesday, September 12, 2012 7:49 PM
> >>> Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
> >>>
> >>>
> >>> Hi folks!
> >>>
> >>> I would like to start with a hot-fix release of OWB (version 1.1.6)
> end
> > of this week.
> >>> Thomas, is this an ok timeframe in which you can fix the issues you
> > needed for your production?
> >>>
> >>> LIeGrue,
> >>> strub
> >>>
> >>>
> >>>
> >>>
> >>>
> >>
> >
>
Re: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Mark Struberg <st...@yahoo.de>.
yikes, yes, will do that now upfront!
I also catched a NPE in AbstractContext.
We can fix that one and do tests while we do the buildtools release.
LieGrue,
strub
----- Original Message -----
> From: David Blevins <da...@gmail.com>
> To: dev@openwebbeans.apache.org; Mark Struberg <st...@yahoo.de>
> Cc:
> Sent: Sunday, September 16, 2012 10:23 PM
> Subject: Re: [DISCUSS] release OWB-1.1.6 end of this week?
>
> Don't forget we also need a build-tools release.
>
>
> On Sep 15, 2012, at 2:32 AM, Mark Struberg wrote:
>
>> Hi David!
>>
>> I can roll the release tonight or tomorrow morning.
>> Udo still likes to get a few things done afaik. UnitTests and stuff...
>>
>>
>> Thomas, did you commit all your changes which you have Jiras created for?
>>
>> LieGrue,
>> strub
>>
>>
>>
>> ----- Original Message -----
>>> From: David Blevins <da...@gmail.com>
>>> To: dev@openwebbeans.apache.org; Mark Struberg
> <st...@yahoo.de>
>>> Cc:
>>> Sent: Saturday, September 15, 2012 10:56 AM
>>> Subject: Re: [DISCUSS] release OWB-1.1.6 end of this week?
>>>
>>> G ot the ASM support finished. OWB-701 officially closed.
>>>
>>> We still use Javassist by default, but we have the ability to use ASM.
>>>
>>> Mark, do you need help with the release? (I know you have a *very*
> busy week
>>> coming up :)
>>>
>>>
>>> -David
>>>
>>> On Sep 12, 2012, at 11:03 AM, Mark Struberg wrote:
>>>
>>>> 2nd try as my previous got eaten by the spam filter :/
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> ----- Forwarded Message -----
>>>>> From: Mark Struberg <st...@yahoo.de>
>>>>> To: openwebbeans-dev <de...@openwebbeans.apache.org>
>>>>> Sent: Wednesday, September 12, 2012 7:49 PM
>>>>> Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>>>>>
>>>>>
>>>>> Hi folks!
>>>>>
>>>>> I would like to start with a hot-fix release of OWB (version
> 1.1.6) end
>>> of this week.
>>>>> Thomas, is this an ok timeframe in which you can fix the issues
> you
>>> needed for your production?
>>>>>
>>>>> LIeGrue,
>>>>> strub
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>
Re: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by David Blevins <da...@gmail.com>.
Don't forget we also need a build-tools release.
On Sep 15, 2012, at 2:32 AM, Mark Struberg wrote:
> Hi David!
>
> I can roll the release tonight or tomorrow morning.
> Udo still likes to get a few things done afaik. UnitTests and stuff...
>
>
> Thomas, did you commit all your changes which you have Jiras created for?
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: David Blevins <da...@gmail.com>
>> To: dev@openwebbeans.apache.org; Mark Struberg <st...@yahoo.de>
>> Cc:
>> Sent: Saturday, September 15, 2012 10:56 AM
>> Subject: Re: [DISCUSS] release OWB-1.1.6 end of this week?
>>
>> G ot the ASM support finished. OWB-701 officially closed.
>>
>> We still use Javassist by default, but we have the ability to use ASM.
>>
>> Mark, do you need help with the release? (I know you have a *very* busy week
>> coming up :)
>>
>>
>> -David
>>
>> On Sep 12, 2012, at 11:03 AM, Mark Struberg wrote:
>>
>>> 2nd try as my previous got eaten by the spam filter :/
>>>
>>>
>>>
>>>
>>>
>>> ----- Forwarded Message -----
>>>> From: Mark Struberg <st...@yahoo.de>
>>>> To: openwebbeans-dev <de...@openwebbeans.apache.org>
>>>> Sent: Wednesday, September 12, 2012 7:49 PM
>>>> Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>>>>
>>>>
>>>> Hi folks!
>>>>
>>>> I would like to start with a hot-fix release of OWB (version 1.1.6) end
>> of this week.
>>>> Thomas, is this an ok timeframe in which you can fix the issues you
>> needed for your production?
>>>>
>>>> LIeGrue,
>>>> strub
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>
Re: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Udo Schnurpfeil <ud...@schnurpfeil.de>.
Hi!
Yes, I've put the stuff as a diff+comment in OWB-703. It would be nice
if somebody can check and commit it.
Regards,
Udo
Am 15.09.12 11:32, schrieb Mark Struberg:
> Hi David!
>
> I can roll the release tonight or tomorrow morning.
> Udo still likes to get a few things done afaik. UnitTests and stuff...
>
>
> Thomas, did you commit all your changes which you have Jiras created for?
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: David Blevins <da...@gmail.com>
>> To: dev@openwebbeans.apache.org; Mark Struberg <st...@yahoo.de>
>> Cc:
>> Sent: Saturday, September 15, 2012 10:56 AM
>> Subject: Re: [DISCUSS] release OWB-1.1.6 end of this week?
>>
>> G ot the ASM support finished. OWB-701 officially closed.
>>
>> We still use Javassist by default, but we have the ability to use ASM.
>>
>> Mark, do you need help with the release? (I know you have a *very* busy week
>> coming up :)
>>
>>
>> -David
>>
>> On Sep 12, 2012, at 11:03 AM, Mark Struberg wrote:
>>
>>> 2nd try as my previous got eaten by the spam filter :/
>>>
>>>
>>>
>>>
>>>
>>> ----- Forwarded Message -----
>>>> From: Mark Struberg <st...@yahoo.de>
>>>> To: openwebbeans-dev <de...@openwebbeans.apache.org>
>>>> Sent: Wednesday, September 12, 2012 7:49 PM
>>>> Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>>>>
>>>>
>>>> Hi folks!
>>>>
>>>> I would like to start with a hot-fix release of OWB (version 1.1.6) end
>> of this week.
>>>> Thomas, is this an ok timeframe in which you can fix the issues you
>> needed for your production?
>>>>
>>>> LIeGrue,
>>>> strub
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>
Re: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Mark Struberg <st...@yahoo.de>.
Hi David!
I can roll the release tonight or tomorrow morning.
Udo still likes to get a few things done afaik. UnitTests and stuff...
Thomas, did you commit all your changes which you have Jiras created for?
LieGrue,
strub
----- Original Message -----
> From: David Blevins <da...@gmail.com>
> To: dev@openwebbeans.apache.org; Mark Struberg <st...@yahoo.de>
> Cc:
> Sent: Saturday, September 15, 2012 10:56 AM
> Subject: Re: [DISCUSS] release OWB-1.1.6 end of this week?
>
>G ot the ASM support finished. OWB-701 officially closed.
>
> We still use Javassist by default, but we have the ability to use ASM.
>
> Mark, do you need help with the release? (I know you have a *very* busy week
> coming up :)
>
>
> -David
>
> On Sep 12, 2012, at 11:03 AM, Mark Struberg wrote:
>
>> 2nd try as my previous got eaten by the spam filter :/
>>
>>
>>
>>
>>
>> ----- Forwarded Message -----
>>> From: Mark Struberg <st...@yahoo.de>
>>> To: openwebbeans-dev <de...@openwebbeans.apache.org>
>>> Sent: Wednesday, September 12, 2012 7:49 PM
>>> Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>>>
>>>
>>> Hi folks!
>>>
>>> I would like to start with a hot-fix release of OWB (version 1.1.6) end
> of this week.
>>> Thomas, is this an ok timeframe in which you can fix the issues you
> needed for your production?
>>>
>>> LIeGrue,
>>> strub
>>>
>>>
>>>
>>>
>>>
>>
>
Re: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by David Blevins <da...@gmail.com>.
Got the ASM support finished. OWB-701 officially closed.
We still use Javassist by default, but we have the ability to use ASM.
Mark, do you need help with the release? (I know you have a *very* busy week coming up :)
-David
On Sep 12, 2012, at 11:03 AM, Mark Struberg wrote:
> 2nd try as my previous got eaten by the spam filter :/
>
>
>
>
>
> ----- Forwarded Message -----
>> From: Mark Struberg <st...@yahoo.de>
>> To: openwebbeans-dev <de...@openwebbeans.apache.org>
>> Sent: Wednesday, September 12, 2012 7:49 PM
>> Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>>
>>
>> Hi folks!
>>
>> I would like to start with a hot-fix release of OWB (version 1.1.6) end of this week.
>> Thomas, is this an ok timeframe in which you can fix the issues you needed for your production?
>>
>> LIeGrue,
>> strub
>>
>>
>>
>>
>>
>
Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Udo Schnurpfeil <ud...@schnurpfeil.de>.
Hi,
I would like to make some tests (and may be optimization) on OWB-703
before the release. I can do that tomorrow.
When do you want to start the release? (Not before Friday evening?)
Regards,
Udo
Am 12.09.12 20:03, schrieb Mark Struberg:
> 2nd try as my previous got eaten by the spam filter :/
>
>
>
>
>
> ----- Forwarded Message -----
>> From: Mark Struberg <st...@yahoo.de>
>> To: openwebbeans-dev <de...@openwebbeans.apache.org>
>> Sent: Wednesday, September 12, 2012 7:49 PM
>> Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>>
>>
>> Hi folks!
>>
>> I would like to start with a hot-fix release of OWB (version 1.1.6) end of this week.
>> Thomas, is this an ok timeframe in which you can fix the issues you needed for your production?
>>
>> LIeGrue,
>> strub
>>
>>
>>
>>
>>
>
Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Mark Struberg <st...@yahoo.de>.
No, lets ship this one with javassist still, I'd say.
There are really a few nasty things in 1.1.5 which I like to get from the table quickly.
Removing javassist in favour to a native asm based solution would for sure take a while.
LieGrue,
strub
----- Original Message -----
> From: Romain Manni-Bucau <rm...@gmail.com>
> To: dev@openwebbeans.apache.org
> Cc:
> Sent: Wednesday, September 12, 2012 8:25 PM
> Subject: Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
>
> HI Mark,
>
> ok for me,
>
> what about javassist issue, do we fix it?
>
> *Romain Manni-Bucau*
> *Twitter: @rmannibucau*
> *Blog: http://rmannibucau.wordpress.com*
>
>
>
>
> 2012/9/12 Thomas Andraschko <zo...@gmail.com>
>
>> Hi Mark,
>>
>> it's already fixed but i attached an patch with some refactoring +
>> unittests to #OWB-702.
>> I know that i could commit it but it would be great if anyone could review
>> it :)
>>
>> Regards,
>> Thomas
>>
>> 2012/9/12 Mark Struberg <st...@yahoo.de>
>>
>> > 2nd try as my previous got eaten by the spam filter :/
>> >
>> >
>> >
>> >
>> >
>> > ----- Forwarded Message -----
>> > >From: Mark Struberg <st...@yahoo.de>
>> > >To: openwebbeans-dev <de...@openwebbeans.apache.org>
>> > >Sent: Wednesday, September 12, 2012 7:49 PM
>> > >Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>> > >
>> > >
>> > >Hi folks!
>> > >
>> > >I would like to start with a hot-fix release of OWB (version
> 1.1.6) end
>> > of this week.
>> > >Thomas, is this an ok timeframe in which you can fix the issues
> you
>> > needed for your production?
>> > >
>> > >LIeGrue,
>> > >strub
>> > >
>> > >
>> > >
>> > >
>> > >
>> >
>>
>
Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
HI Mark,
ok for me,
what about javassist issue, do we fix it?
*Romain Manni-Bucau*
*Twitter: @rmannibucau*
*Blog: http://rmannibucau.wordpress.com*
2012/9/12 Thomas Andraschko <zo...@gmail.com>
> Hi Mark,
>
> it's already fixed but i attached an patch with some refactoring +
> unittests to #OWB-702.
> I know that i could commit it but it would be great if anyone could review
> it :)
>
> Regards,
> Thomas
>
> 2012/9/12 Mark Struberg <st...@yahoo.de>
>
> > 2nd try as my previous got eaten by the spam filter :/
> >
> >
> >
> >
> >
> > ----- Forwarded Message -----
> > >From: Mark Struberg <st...@yahoo.de>
> > >To: openwebbeans-dev <de...@openwebbeans.apache.org>
> > >Sent: Wednesday, September 12, 2012 7:49 PM
> > >Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
> > >
> > >
> > >Hi folks!
> > >
> > >I would like to start with a hot-fix release of OWB (version 1.1.6) end
> > of this week.
> > >Thomas, is this an ok timeframe in which you can fix the issues you
> > needed for your production?
> > >
> > >LIeGrue,
> > >strub
> > >
> > >
> > >
> > >
> > >
> >
>
Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Mark Struberg <st...@yahoo.de>.
Yes remove all auto format stuff from your IDE please. And also all automated import ordering.
That usually just messes up every commit and pollutes the commit history. Every IDE (sometimes even version) does this different thus we would just override changes from the previous committer.
And please also only use spaces. We shall not have a single tab in our sources :)
I always suggest to enable whitespace viewing in your IDE.
LieGrue,
strub
----- Original Message -----
> From: Thomas Andraschko <zo...@gmail.com>
> To: dev@openwebbeans.apache.org
> Cc:
> Sent: Wednesday, September 12, 2012 8:38 PM
> Subject: Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
>
> i know, sorry. Should i deactivate "remove trailing spaces" in my IDE?
>
> 2012/9/12 Joseph Bergmark <be...@apache.org>
>
>> I started to review the patch, and the changes I saw looked good, but
>> there is so much whitespace reformatting in that patch that its hard
>> to focus on just the implementation changes.
>>
>> Sincerely,
>>
>> Joe
>>
>> On Wed, Sep 12, 2012 at 2:24 PM, Thomas Andraschko <zo...@gmail.com>
>> wrote:
>> > Hi Mark,
>> >
>> > it's already fixed but i attached an patch with some refactoring +
>> > unittests to #OWB-702.
>> > I know that i could commit it but it would be great if anyone could
>> review
>> > it :)
>> >
>> > Regards,
>> > Thomas
>> >
>> > 2012/9/12 Mark Struberg <st...@yahoo.de>
>> >
>> >> 2nd try as my previous got eaten by the spam filter :/
>> >>
>> >>
>> >>
>> >>
>> >>
>> >> ----- Forwarded Message -----
>> >> >From: Mark Struberg <st...@yahoo.de>
>> >> >To: openwebbeans-dev <de...@openwebbeans.apache.org>
>> >> >Sent: Wednesday, September 12, 2012 7:49 PM
>> >> >Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>> >> >
>> >> >
>> >> >Hi folks!
>> >> >
>> >> >I would like to start with a hot-fix release of OWB (version
> 1.1.6) end
>> >> of this week.
>> >> >Thomas, is this an ok timeframe in which you can fix the
> issues you
>> >> needed for your production?
>> >> >
>> >> >LIeGrue,
>> >> >strub
>> >> >
>> >> >
>> >> >
>> >> >
>> >> >
>> >>
>>
>
Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
@Mark: spoke about finalize, not asm issue
*Romain Manni-Bucau*
*Twitter: @rmannibucau*
*Blog: http://rmannibucau.wordpress.com*
2012/9/12 Joseph Bergmark <be...@apache.org>
> I'm not at all sure whats leading to the whitespace differences. Do
> you use Eclipse? If so I can send you the eclipse formatter that
> Gurkan sent me a couple years back.
>
> Sincerely,
>
> Joe
>
> On Wed, Sep 12, 2012 at 2:38 PM, Thomas Andraschko <zo...@gmail.com>
> wrote:
> > i know, sorry. Should i deactivate "remove trailing spaces" in my IDE?
> >
> > 2012/9/12 Joseph Bergmark <be...@apache.org>
> >
> >> I started to review the patch, and the changes I saw looked good, but
> >> there is so much whitespace reformatting in that patch that its hard
> >> to focus on just the implementation changes.
> >>
> >> Sincerely,
> >>
> >> Joe
> >>
> >> On Wed, Sep 12, 2012 at 2:24 PM, Thomas Andraschko <zo...@gmail.com>
> >> wrote:
> >> > Hi Mark,
> >> >
> >> > it's already fixed but i attached an patch with some refactoring +
> >> > unittests to #OWB-702.
> >> > I know that i could commit it but it would be great if anyone could
> >> review
> >> > it :)
> >> >
> >> > Regards,
> >> > Thomas
> >> >
> >> > 2012/9/12 Mark Struberg <st...@yahoo.de>
> >> >
> >> >> 2nd try as my previous got eaten by the spam filter :/
> >> >>
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> ----- Forwarded Message -----
> >> >> >From: Mark Struberg <st...@yahoo.de>
> >> >> >To: openwebbeans-dev <de...@openwebbeans.apache.org>
> >> >> >Sent: Wednesday, September 12, 2012 7:49 PM
> >> >> >Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
> >> >> >
> >> >> >
> >> >> >Hi folks!
> >> >> >
> >> >> >I would like to start with a hot-fix release of OWB (version 1.1.6)
> end
> >> >> of this week.
> >> >> >Thomas, is this an ok timeframe in which you can fix the issues you
> >> >> needed for your production?
> >> >> >
> >> >> >LIeGrue,
> >> >> >strub
> >> >> >
> >> >> >
> >> >> >
> >> >> >
> >> >> >
> >> >>
> >>
>
Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Thomas Andraschko <zo...@gmail.com>.
@Joe
Yey, i use eclipse :) That would be great!
@Mark
all right, thanks for the infos!
2012/9/12 Joseph Bergmark <be...@apache.org>
> I'm not at all sure whats leading to the whitespace differences. Do
> you use Eclipse? If so I can send you the eclipse formatter that
> Gurkan sent me a couple years back.
>
> Sincerely,
>
> Joe
>
> On Wed, Sep 12, 2012 at 2:38 PM, Thomas Andraschko <zo...@gmail.com>
> wrote:
> > i know, sorry. Should i deactivate "remove trailing spaces" in my IDE?
> >
> > 2012/9/12 Joseph Bergmark <be...@apache.org>
> >
> >> I started to review the patch, and the changes I saw looked good, but
> >> there is so much whitespace reformatting in that patch that its hard
> >> to focus on just the implementation changes.
> >>
> >> Sincerely,
> >>
> >> Joe
> >>
> >> On Wed, Sep 12, 2012 at 2:24 PM, Thomas Andraschko <zo...@gmail.com>
> >> wrote:
> >> > Hi Mark,
> >> >
> >> > it's already fixed but i attached an patch with some refactoring +
> >> > unittests to #OWB-702.
> >> > I know that i could commit it but it would be great if anyone could
> >> review
> >> > it :)
> >> >
> >> > Regards,
> >> > Thomas
> >> >
> >> > 2012/9/12 Mark Struberg <st...@yahoo.de>
> >> >
> >> >> 2nd try as my previous got eaten by the spam filter :/
> >> >>
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> ----- Forwarded Message -----
> >> >> >From: Mark Struberg <st...@yahoo.de>
> >> >> >To: openwebbeans-dev <de...@openwebbeans.apache.org>
> >> >> >Sent: Wednesday, September 12, 2012 7:49 PM
> >> >> >Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
> >> >> >
> >> >> >
> >> >> >Hi folks!
> >> >> >
> >> >> >I would like to start with a hot-fix release of OWB (version 1.1.6)
> end
> >> >> of this week.
> >> >> >Thomas, is this an ok timeframe in which you can fix the issues you
> >> >> needed for your production?
> >> >> >
> >> >> >LIeGrue,
> >> >> >strub
> >> >> >
> >> >> >
> >> >> >
> >> >> >
> >> >> >
> >> >>
> >>
>
Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Joseph Bergmark <be...@apache.org>.
I'm not at all sure whats leading to the whitespace differences. Do
you use Eclipse? If so I can send you the eclipse formatter that
Gurkan sent me a couple years back.
Sincerely,
Joe
On Wed, Sep 12, 2012 at 2:38 PM, Thomas Andraschko <zo...@gmail.com> wrote:
> i know, sorry. Should i deactivate "remove trailing spaces" in my IDE?
>
> 2012/9/12 Joseph Bergmark <be...@apache.org>
>
>> I started to review the patch, and the changes I saw looked good, but
>> there is so much whitespace reformatting in that patch that its hard
>> to focus on just the implementation changes.
>>
>> Sincerely,
>>
>> Joe
>>
>> On Wed, Sep 12, 2012 at 2:24 PM, Thomas Andraschko <zo...@gmail.com>
>> wrote:
>> > Hi Mark,
>> >
>> > it's already fixed but i attached an patch with some refactoring +
>> > unittests to #OWB-702.
>> > I know that i could commit it but it would be great if anyone could
>> review
>> > it :)
>> >
>> > Regards,
>> > Thomas
>> >
>> > 2012/9/12 Mark Struberg <st...@yahoo.de>
>> >
>> >> 2nd try as my previous got eaten by the spam filter :/
>> >>
>> >>
>> >>
>> >>
>> >>
>> >> ----- Forwarded Message -----
>> >> >From: Mark Struberg <st...@yahoo.de>
>> >> >To: openwebbeans-dev <de...@openwebbeans.apache.org>
>> >> >Sent: Wednesday, September 12, 2012 7:49 PM
>> >> >Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>> >> >
>> >> >
>> >> >Hi folks!
>> >> >
>> >> >I would like to start with a hot-fix release of OWB (version 1.1.6) end
>> >> of this week.
>> >> >Thomas, is this an ok timeframe in which you can fix the issues you
>> >> needed for your production?
>> >> >
>> >> >LIeGrue,
>> >> >strub
>> >> >
>> >> >
>> >> >
>> >> >
>> >> >
>> >>
>>
Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Thomas Andraschko <zo...@gmail.com>.
i know, sorry. Should i deactivate "remove trailing spaces" in my IDE?
2012/9/12 Joseph Bergmark <be...@apache.org>
> I started to review the patch, and the changes I saw looked good, but
> there is so much whitespace reformatting in that patch that its hard
> to focus on just the implementation changes.
>
> Sincerely,
>
> Joe
>
> On Wed, Sep 12, 2012 at 2:24 PM, Thomas Andraschko <zo...@gmail.com>
> wrote:
> > Hi Mark,
> >
> > it's already fixed but i attached an patch with some refactoring +
> > unittests to #OWB-702.
> > I know that i could commit it but it would be great if anyone could
> review
> > it :)
> >
> > Regards,
> > Thomas
> >
> > 2012/9/12 Mark Struberg <st...@yahoo.de>
> >
> >> 2nd try as my previous got eaten by the spam filter :/
> >>
> >>
> >>
> >>
> >>
> >> ----- Forwarded Message -----
> >> >From: Mark Struberg <st...@yahoo.de>
> >> >To: openwebbeans-dev <de...@openwebbeans.apache.org>
> >> >Sent: Wednesday, September 12, 2012 7:49 PM
> >> >Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
> >> >
> >> >
> >> >Hi folks!
> >> >
> >> >I would like to start with a hot-fix release of OWB (version 1.1.6) end
> >> of this week.
> >> >Thomas, is this an ok timeframe in which you can fix the issues you
> >> needed for your production?
> >> >
> >> >LIeGrue,
> >> >strub
> >> >
> >> >
> >> >
> >> >
> >> >
> >>
>
Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Joseph Bergmark <be...@apache.org>.
I started to review the patch, and the changes I saw looked good, but
there is so much whitespace reformatting in that patch that its hard
to focus on just the implementation changes.
Sincerely,
Joe
On Wed, Sep 12, 2012 at 2:24 PM, Thomas Andraschko <zo...@gmail.com> wrote:
> Hi Mark,
>
> it's already fixed but i attached an patch with some refactoring +
> unittests to #OWB-702.
> I know that i could commit it but it would be great if anyone could review
> it :)
>
> Regards,
> Thomas
>
> 2012/9/12 Mark Struberg <st...@yahoo.de>
>
>> 2nd try as my previous got eaten by the spam filter :/
>>
>>
>>
>>
>>
>> ----- Forwarded Message -----
>> >From: Mark Struberg <st...@yahoo.de>
>> >To: openwebbeans-dev <de...@openwebbeans.apache.org>
>> >Sent: Wednesday, September 12, 2012 7:49 PM
>> >Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
>> >
>> >
>> >Hi folks!
>> >
>> >I would like to start with a hot-fix release of OWB (version 1.1.6) end
>> of this week.
>> >Thomas, is this an ok timeframe in which you can fix the issues you
>> needed for your production?
>> >
>> >LIeGrue,
>> >strub
>> >
>> >
>> >
>> >
>> >
>>
Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?
Posted by Thomas Andraschko <zo...@gmail.com>.
Hi Mark,
it's already fixed but i attached an patch with some refactoring +
unittests to #OWB-702.
I know that i could commit it but it would be great if anyone could review
it :)
Regards,
Thomas
2012/9/12 Mark Struberg <st...@yahoo.de>
> 2nd try as my previous got eaten by the spam filter :/
>
>
>
>
>
> ----- Forwarded Message -----
> >From: Mark Struberg <st...@yahoo.de>
> >To: openwebbeans-dev <de...@openwebbeans.apache.org>
> >Sent: Wednesday, September 12, 2012 7:49 PM
> >Subject: [DISCUSS] releaese OWB-1.1.6 end of this week?
> >
> >
> >Hi folks!
> >
> >I would like to start with a hot-fix release of OWB (version 1.1.6) end
> of this week.
> >Thomas, is this an ok timeframe in which you can fix the issues you
> needed for your production?
> >
> >LIeGrue,
> >strub
> >
> >
> >
> >
> >
>