You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by heary-cao <gi...@git.apache.org> on 2018/02/12 02:46:10 UTC
[GitHub] spark pull request #20582: [MINOR][TEST]`spark.testing` No effect on the Spa...
GitHub user heary-cao opened a pull request:
https://github.com/apache/spark/pull/20582
[MINOR][TEST]`spark.testing` No effect on the SparkFunSuite unit test
## What changes were proposed in this pull request?
Currently, we use SBT and MAVN to spark unit test, are affected by the parameters of `spark.testing`. However, when using the IDE test tool, `spark.testing` support is not very good, sometimes need to be manually added to the beforeEach. example: HiveSparkSubmitSuite RPackageUtilsSuite SparkSubmitSuite. The PR unified `spark.testing` parameter extraction to SparkFunSuite, support IDE test tool, and the test code is more compact.
## How was this patch tested?
the existed test cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/heary-cao/spark sparktesting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20582.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20582
----
commit 512792d27a03bd1ca79916d7a8d69ac3f9182626
Author: caoxuewen <ca...@...>
Date: 2018-02-12T01:51:51Z
fix
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20582
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20582
**[Test build #87330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87330/testReport)** for PR 20582 at commit [`512792d`](https://github.com/apache/spark/commit/512792d27a03bd1ca79916d7a8d69ac3f9182626).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20582: [MINOR][TEST]`spark.testing` No effect on the Spa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20582
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20582
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/20582
@cloud-fan @srowen Can you help me to review it , thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20582: [MINOR][TEST]`spark.testing` No effect on the Spa...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20582#discussion_r167468000
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -50,7 +50,6 @@ class HiveSparkSubmitSuite
override def beforeEach() {
super.beforeEach()
- System.setProperty("spark.testing", "true")
--- End diff --
is there any more places to remove?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20582
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20582
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20582
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87330/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20582
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20582
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87322/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20582
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20582
thanks, merging to master!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20582
**[Test build #87330 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87330/testReport)** for PR 20582 at commit [`512792d`](https://github.com/apache/spark/commit/512792d27a03bd1ca79916d7a8d69ac3f9182626).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20582
**[Test build #87322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87322/testReport)** for PR 20582 at commit [`512792d`](https://github.com/apache/spark/commit/512792d27a03bd1ca79916d7a8d69ac3f9182626).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20582: [MINOR][TEST]`spark.testing` No effect on the SparkFunSu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20582
**[Test build #87322 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87322/testReport)** for PR 20582 at commit [`512792d`](https://github.com/apache/spark/commit/512792d27a03bd1ca79916d7a8d69ac3f9182626).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20582: [MINOR][TEST]`spark.testing` No effect on the Spa...
Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20582#discussion_r167486532
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -50,7 +50,6 @@ class HiveSparkSubmitSuite
override def beforeEach() {
super.beforeEach()
- System.setProperty("spark.testing", "true")
--- End diff --
All the code was searched, and it was not found for the time being. thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org