You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/10/29 23:26:15 UTC

Review Request 27353: Clean up code for linux namespaces.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27353/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos-git


Description
-------

Deferred cleanup from https://reviews.apache.org/r/27091/

Remove naming redundancy, e.g., ns::setns() -> ns::set().
Add ns::supported(string) helper.


Diffs
-----

  src/linux/ns.hpp ec1a5171c8923d8661caab9999d0d73d5140bee4 
  src/slave/containerizer/isolators/namespaces/pid.cpp edfb1f64fb535d826886922788d95d0850f49b3e 
  src/slave/containerizer/isolators/network/port_mapping.cpp 14fae1f00050afbc6b99f4aabf868a2d75774b15 
  src/tests/isolator_tests.cpp 4d03f46cbe20c0e7aff15bab0a26d7738b55aab9 
  src/tests/ns_tests.cpp 046ea26701f346399f4bc31a5c9491325e8bd93f 
  src/tests/setns_test_helper.cpp eb8746bd6e75323682d9dbbf989b65e30e3c1cda 

Diff: https://reviews.apache.org/r/27353/diff/


Testing
-------

make check


Thanks,

Ian Downes

Re: Review Request 27353: Clean up code for linux namespaces.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27353/#review59077
-----------------------------------------------------------


Patch looks great!

Reviews applied: [27353]

All tests passed.

- Mesos ReviewBot


On Oct. 29, 2014, 10:26 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27353/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 10:26 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Deferred cleanup from https://reviews.apache.org/r/27091/
> 
> Remove naming redundancy, e.g., ns::setns() -> ns::set().
> Add ns::supported(string) helper.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp ec1a5171c8923d8661caab9999d0d73d5140bee4 
>   src/slave/containerizer/isolators/namespaces/pid.cpp edfb1f64fb535d826886922788d95d0850f49b3e 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 14fae1f00050afbc6b99f4aabf868a2d75774b15 
>   src/tests/isolator_tests.cpp 4d03f46cbe20c0e7aff15bab0a26d7738b55aab9 
>   src/tests/ns_tests.cpp 046ea26701f346399f4bc31a5c9491325e8bd93f 
>   src/tests/setns_test_helper.cpp eb8746bd6e75323682d9dbbf989b65e30e3c1cda 
> 
> Diff: https://reviews.apache.org/r/27353/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>