You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "IOhacker (via GitHub)" <gi...@apache.org> on 2024/05/10 02:36:27 UTC

[PR] Github Action for DockerHub Publishing [fineract]

IOhacker opened a new pull request, #3887:
URL: https://github.com/apache/fineract/pull/3887

   ## Description
   
   Github Action for DockerHub Publishing
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Github Action for DockerHub Publishing [fineract]

Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #3887:
URL: https://github.com/apache/fineract/pull/3887#issuecomment-2133606164

   @galovics I am unable to use JIB for arm builds. I have added the platforms in the build.gradle file. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Github Action for DockerHub Publishing [fineract]

Posted by "jdailey (via GitHub)" <gi...@apache.org>.
jdailey merged PR #3887:
URL: https://github.com/apache/fineract/pull/3887


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Github Action for DockerHub Publishing [fineract]

Posted by "jdailey (via GitHub)" <gi...@apache.org>.
jdailey commented on PR #3887:
URL: https://github.com/apache/fineract/pull/3887#issuecomment-2135872474

   LGTM and should not conflict with any other work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Github Action for DockerHub Publishing [fineract]

Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #3887:
URL: https://github.com/apache/fineract/pull/3887#issuecomment-2136021409

   @jdailey changes have been done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org