[Impala-ASF-CR] IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1

["Attila Jeges (Code Review)" <ge...@cloudera.org>]

Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13722 )

Change subject: IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13722/15/be/src/runtime/datetime-iso-sql-format-parser.cc
File be/src/runtime/datetime-iso-sql-format-parser.cc:

http://gerrit.cloudera.org:8080/#/c/13722/15/be/src/runtime/datetime-iso-sql-format-parser.cc@144
PS15, Line 144: 0, 99
> The sign before TIMEZONE_HOUR is processed in FindEndOfToken(). See L226.
Ok, I checked out your change and run some tests. This works:
> select cast('2018-12-31 08:00 1' as timestamp FORMAT 'YYYY-MM-DD HH24:MI TZH');
2018-12-31 08:00:00

But this doesn't:
> select cast('2018-12-31 08:00 -1' as timestamp FORMAT 'YYYY-MM-DD HH24:MI TZH');
NULL


Am I missing something?



-- 
To view, visit http://gerrit.cloudera.org:8080/13722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d8d097a45ae6f103b6cd1b2d81aad38dfd9e23
Gerrit-Change-Number: 13722
Gerrit-PatchSet: 15
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Sep 2019 13:28:47 +0000
Gerrit-HasComments: Yes