You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/09 10:39:20 UTC

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1315: Fix hello_zig build break

pkarashchenko commented on code in PR #1315:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1315#discussion_r966900870


##########
Application.mk:
##########
@@ -127,7 +127,8 @@ endef
 
 define ELFCOMPILEZIG
        @echo "ZIG: $1"
-       $(Q) $(ZIG) build-obj $(ZIGELFFLAGS) $($(strip $1)_ZIGELFFLAGS) $1 --name $2
+	   # Remove target suffix here since zig compiler add .o automatically

Review Comment:
   ```suggestion
   	# Remove target suffix here since zig compiler add .o automatically
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org