You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/18 12:38:49 UTC

[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

GutoVeronezi opened a new pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702


   ### Description
   This PR intends to improve logging in the class `IpmitoolOutOfBandManagementDriver` to facilitate troubleshooting.
   
   ### Types of changes
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functioanlity)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   - [ ] Major
   - [x] Minor
   
   ### How Has This Been Tested?
   It has been tested locally on a test lab.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#issuecomment-818036754


   Re-kicking travis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#issuecomment-791913307


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2881


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#issuecomment-791902453


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd closed pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#issuecomment-817792505


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 396


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rafaelweingartner commented on a change in pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
rafaelweingartner commented on a change in pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#discussion_r578642883



##########
File path: plugins/outofbandmanagement-drivers/ipmitool/src/main/java/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolOutOfBandManagementDriver.java
##########
@@ -37,6 +37,7 @@
 import java.util.List;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
+import org.apache.commons.lang3.StringUtils;

Review comment:
       So, lets add a facade to Spring as well, and to any other utils library that we use :)
   
   I still see no benefits on creating such facades.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#discussion_r578500982



##########
File path: plugins/outofbandmanagement-drivers/ipmitool/src/main/java/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolOutOfBandManagementDriver.java
##########
@@ -37,6 +37,7 @@
 import java.util.List;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
+import org.apache.commons.lang3.StringUtils;

Review comment:
       yes we do, and we are badly hampered in most cases where we don't (gson/logging mostly)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#issuecomment-817775333


   @GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#issuecomment-817774433


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#discussion_r579080201



##########
File path: plugins/outofbandmanagement-drivers/ipmitool/src/main/java/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolOutOfBandManagementDriver.java
##########
@@ -37,6 +37,7 @@
 import java.util.List;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
+import org.apache.commons.lang3.StringUtils;

Review comment:
       that is a lazy exaggeration, we have a facade for string utils and we are hampered by several 3rd party libraries for which we don't. If there are resources for making such a thing for spring, great. Let's do it.
   
   BTW, in this case I didn't :-1: on this issue, but on other counts I might as well. duckduck "using 3rd party library facades", will give you some wisdom on this.
   
   out




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#discussion_r578468551



##########
File path: plugins/outofbandmanagement-drivers/ipmitool/src/main/java/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolOutOfBandManagementDriver.java
##########
@@ -37,6 +37,7 @@
 import java.util.List;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
+import org.apache.commons.lang3.StringUtils;

Review comment:
       please use our own (cloudstack) Stringutils as proxy, even when calling the apache.commons




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#issuecomment-791902566


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rafaelweingartner commented on a change in pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
rafaelweingartner commented on a change in pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#discussion_r578486328



##########
File path: plugins/outofbandmanagement-drivers/ipmitool/src/main/java/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolOutOfBandManagementDriver.java
##########
@@ -37,6 +37,7 @@
 import java.util.List;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
+import org.apache.commons.lang3.StringUtils;

Review comment:
       There is no consensus on that. I would prefer this way, using the library directly. We do not get benefits on a facade like that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#issuecomment-822840068


   @rhtyd @GabrielBrascher @DaanHoogland is there anything else to do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#issuecomment-823847531


   that's a no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org