[jira] [Updated] (YARN-11256) buildCommandExecutor function leverages redundant params

["Bob Thomson (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YARN-11256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Thomson updated YARN-11256:
-------------------------------
    Reporter: Samrat Deb  (was: Bob Thomson)

> buildCommandExecutor function leverages redundant params 
> ---------------------------------------------------------
>
>                 Key: YARN-11256
>                 URL: https://issues.apache.org/jira/browse/YARN-11256
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn
>            Reporter: Samrat Deb
>            Assignee: Samrat Deb
>            Priority: Minor
>              Labels: pull-request-available
>
> Current signature of `buildCommandExecutor` passes redundant params which can be reduced by passing container reference 
>  
> {code:java}
> protected CommandExecutor buildCommandExecutor(String wrapperScriptPath,
> String containerIdStr, String user, Path pidFile, Resource resource,
> File workDir, Map<String, String> environment){code}
>  
>  - `containerIdStr` can be derived from `container.getContainerId().toString()`
>  - `resource` can be derived from `container.getResource()`
>  - `environment` can be derived from container reference 
> this will allow extention of the function without constraining to paramters of the method 
> Container reference is safe as it is pass by reference it wont copy the entire the container object 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org