You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/05 13:21:24 UTC

[GitHub] [flink] 1u0 opened a new pull request #8633: [hotfix] Use proper template format substitute in Preconditions' use

1u0 opened a new pull request #8633: [hotfix] Use proper template format substitute in Preconditions' use
URL: https://github.com/apache/flink/pull/8633
 
 
   ## What is the purpose of the change
   
   This change uses `%s` as format template parameter substitude in some code using `org.apache.flink.util.Preconditions` methods with format string.
   This should improve the thrown errors' messages.
   
   ## Brief change log
   
     - Find and correct some call sites using `Preconditions` methods with format parameters.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   (If we assume that no code relies on exceptions' message string.)
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no** _but may effect thrown exceptions_)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services