You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/03 19:32:37 UTC
[GitHub] [geode] dschneider-pivotal opened a new pull request #5209: GEODE-8211: fix flaky shutdown test
dschneider-pivotal opened a new pull request #5209:
URL: https://github.com/apache/geode/pull/5209
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5209: GEODE-8211: fix flaky shutdown test
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5209:
URL: https://github.com/apache/geode/pull/5209#discussion_r434814571
##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -61,11 +61,7 @@ public void shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
// Unfortunately Jedis' shutdown() doesn't seem to throw a JedisDataException when the command
// returns an error.
- try {
- jedis.shutdown();
- } catch (JedisConnectionException ignore) {
Review comment:
It was throwing this before, intermittently, because the server was actually shutting down intermittently. The point of the test was for shutdown to be a NOOP. But the flag the test sets to make it a noop did not work because the thread reading the flag is in another thread so it sometimes did not see that the command was unsupported. So now with the "volatile" on the boolean, it will always see the change this test makes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jchen21 commented on a change in pull request #5209: GEODE-8211: fix flaky shutdown test
Posted by GitBox <gi...@apache.org>.
jchen21 commented on a change in pull request #5209:
URL: https://github.com/apache/geode/pull/5209#discussion_r434811874
##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -61,11 +61,7 @@ public void shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
// Unfortunately Jedis' shutdown() doesn't seem to throw a JedisDataException when the command
// returns an error.
- try {
- jedis.shutdown();
- } catch (JedisConnectionException ignore) {
Review comment:
Will `jedis.shutdown()` no longer throw `JedisConnectionException`? Or if `JedisConnectionException` is thrown, we just don't want to catch it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5209: GEODE-8211: fix flaky shutdown test
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5209:
URL: https://github.com/apache/geode/pull/5209#discussion_r434814852
##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -61,11 +61,7 @@ public void shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
// Unfortunately Jedis' shutdown() doesn't seem to throw a JedisDataException when the command
// returns an error.
- try {
- jedis.shutdown();
- } catch (JedisConnectionException ignore) {
Review comment:
Also, this fix was already reviewed on another branch. I just wanted it to be isolated on its own PR instead of being part of another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal merged pull request #5209: GEODE-8211: fix flaky shutdown test
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal merged pull request #5209:
URL: https://github.com/apache/geode/pull/5209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org