svn commit: r170093 - /incubator/beehive/trunk/netui/src/testRecorder/org/apache/beehive/netui/tools/testrecorder/server/AbstractDiffEngine.java

[ri...@apache.org]

Author: rich
Date: Fri May 13 14:28:43 2005
New Revision: 170093

URL: http://svn.apache.org/viewcvs?rev=170093&view=rev
Log:
Minor change to make TestRecorder avoid comparing the recorded request URI to the playback request URI.  This is not a valid thing to do, since the Servlet spec doesn't guarantee that they are the same.  Specifically, they can be different when the Servlet container interprets a welcome-file request.

tests: bvt in netui (WinXP)
BB: self (linux)


Modified:
    incubator/beehive/trunk/netui/src/testRecorder/org/apache/beehive/netui/tools/testrecorder/server/AbstractDiffEngine.java

Modified: incubator/beehive/trunk/netui/src/testRecorder/org/apache/beehive/netui/tools/testrecorder/server/AbstractDiffEngine.java
URL: http://svn.apache.org/viewcvs/incubator/beehive/trunk/netui/src/testRecorder/org/apache/beehive/netui/tools/testrecorder/server/AbstractDiffEngine.java?rev=170093&r1=170092&r2=170093&view=diff
==============================================================================
--- incubator/beehive/trunk/netui/src/testRecorder/org/apache/beehive/netui/tools/testrecorder/server/AbstractDiffEngine.java (original)
+++ incubator/beehive/trunk/netui/src/testRecorder/org/apache/beehive/netui/tools/testrecorder/server/AbstractDiffEngine.java Fri May 13 14:28:43 2005
@@ -51,11 +51,11 @@
                     " ) does not match playback request protocol( " +
                     playback.getProtocol() + " )" );
         }
-        if ( !record.getPath().equals( playback.getPath() ) ) {
-            results.addDiffResult( "record request path( " + record.getPath() +
-                    " ) does not match playback request path( " +
-                    playback.getPath() + " )" );
-        }
+        
+        // Note that we do NOT compare the recorded request path with the playback request path, because the Servlet
+        // spec doesn't say that they must be equal.  Specifically, this can break when the container itself interprets
+        // a welcome-page request.
+        
         if ( !record.getMethod().equals( playback.getMethod() ) ) {
             results.addDiffResult( "record request method( " + record.getMethod() +
                     " ) does not match playback request method( " +