You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Jeff Levitt (JIRA)" <de...@db.apache.org> on 2005/05/12 01:45:05 UTC
[jira] Created: (DERBY-274) Document new limits in Derby docs
Document new limits in Derby docs
---------------------------------
Key: DERBY-274
URL: http://issues.apache.org/jira/browse/DERBY-274
Project: Derby
Type: Sub-task
Components: Documentation
Environment: all
Reporter: Jeff Levitt
Assigned to: Jeff Levitt
Priority: Minor
These new limits should be documented. The page I assume most likely needs changes is:
http://incubator.apache.org/derby/docs/ref/rrefidlengthlimits.html
So I am planning on changing all of those to 128. Is that correct?
Also, I did a preliminary search and couldn't find many other instances where we explicitely say anything has a limit of either 30 or 18. The only items I found were that numeric floating point constants are limited to a length of 30 characters, and index names have an 18 character max length. Should either or both of those go to 128? Should either of those or both be placed in the Limitations table (see the link above) as well?
This is an easy patch to create, I can do it really easily if someone can provide me with answers to the above questions.
Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Created: (DERBY-274) Document new limits in Derby docs
Posted by Army <qo...@sbcglobal.net>.
Jeff Levitt (JIRA) wrote:
> Document new limits in Derby docs
> ---------------------------------
[ snip ]
You might want to wait until the patch for DERBY-104 is committed before making
this change. That patch was posted by Bernt Johnsen yesterday morning and I
just reviewed it today. It has yet to be committed.
> These new limits should be documented. [ ... ]
> The only items I found were that numeric floating
> point constants are limited to a length of 30
> characters, and index names have an 18 character
> max length. Should either or both of those go
> to 128? Should either of those or both be
> placed in the Limitations table (see the link
> above) as well?
[ snip ]
Based on the patch proposed by Bernt Johnsen, the length of an index name _is_
going to change to 128, while the max length of a floating point constant is
going to remain at 30. The max length of an index name is already in the table
you mentioned (second row from the bottom, it's given as 18, which will need to
change). Since the table header is "identifier length" and all of the entries
refer to "names", I would think that the floating point limit should not be
included in that table--that's a limit on the literal value itself, not on the
name of any particular database identifier.
Army
[jira] Updated: (DERBY-274) Document new limits in Derby docs
Posted by "Jeff Levitt (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-274?page=all ]
Jeff Levitt updated DERBY-274:
------------------------------
Attachment: derby274.zip
Here is a patch, along with generated html output for review. This patch should only be committed when the parent JIRA issue is committed.
> Document new limits in Derby docs
> ---------------------------------
>
> Key: DERBY-274
> URL: http://issues.apache.org/jira/browse/DERBY-274
> Project: Derby
> Type: Sub-task
> Components: Documentation
> Environment: all
> Reporter: Jeff Levitt
> Assignee: Jeff Levitt
> Priority: Minor
> Attachments: derby274.zip
>
> These new limits should be documented. The page I assume most likely needs changes is:
> http://incubator.apache.org/derby/docs/ref/rrefidlengthlimits.html
> So I am planning on changing all of those to 128. Is that correct?
> Also, I did a preliminary search and couldn't find many other instances where we explicitely say anything has a limit of either 30 or 18. The only items I found were that numeric floating point constants are limited to a length of 30 characters, and index names have an 18 character max length. Should either or both of those go to 128? Should either of those or both be placed in the Limitations table (see the link above) as well?
> This is an easy patch to create, I can do it really easily if someone can provide me with answers to the above questions.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-274) Document new limits in Derby docs
Posted by "Jean T. Anderson (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-274?page=all ]
Jean T. Anderson closed DERBY-274:
----------------------------------
Fix Version: 10.1.0.0
Resolution: Fixed
Committed Jeff's patch, revision 180159, that documents new identifier limits. Files modified:
incubator/derby/docs/trunk/src/ref/rrefidlengthlimits.dita
incubator/derby/docs/trunk/src/ref/rrefsqlj20937.dita
incubator/derby/docs/trunk/src/ref/rrefsqlj31580.dita
Closing as "Fixed" based on Satheesh Bandaram <sa...@Sourcery.Org> comment posted to derby-dev: "I think this patch looks good, though I haven't searched for any other references to older limits on identifier lengths." See http://mail-archives.apache.org/mod_mbox/db-derby-dev/200506.mbox/%3c42A64F0E.6080702@Sourcery.Org%3e
Note that the comment in the commit record at http://mail-archives.apache.org/mod_mbox/db-derby-commits/200506.mbox/%3c20050605223319.41650.qmail@minotaur.apache.org%3e
incorrectly references DERBY-287 instead of DERBY-274. The log comments for the three files were corrected to reference DERBY 274.
> Document new limits in Derby docs
> ---------------------------------
>
> Key: DERBY-274
> URL: http://issues.apache.org/jira/browse/DERBY-274
> Project: Derby
> Type: Sub-task
> Components: Documentation
> Environment: all
> Reporter: Jeff Levitt
> Assignee: Jeff Levitt
> Priority: Minor
> Fix For: 10.1.0.0
> Attachments: derby274.zip
>
> These new limits should be documented. The page I assume most likely needs changes is:
> http://incubator.apache.org/derby/docs/ref/rrefidlengthlimits.html
> So I am planning on changing all of those to 128. Is that correct?
> Also, I did a preliminary search and couldn't find many other instances where we explicitely say anything has a limit of either 30 or 18. The only items I found were that numeric floating point constants are limited to a length of 30 characters, and index names have an 18 character max length. Should either or both of those go to 128? Should either of those or both be placed in the Limitations table (see the link above) as well?
> This is an easy patch to create, I can do it really easily if someone can provide me with answers to the above questions.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira