You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/26 18:28:13 UTC
[GitHub] GJL commented on a change in pull request #6734: [FLINK-9455][RM]
Add support for multi task slot TaskExecutors
GJL commented on a change in pull request #6734: [FLINK-9455][RM] Add support for multi task slot TaskExecutors
URL: https://github.com/apache/flink/pull/6734#discussion_r220674263
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -1176,8 +1177,22 @@ public void reportPayload(ResourceID resourceID, Void payload) {
// Resource Management
// ------------------------------------------------------------------------
- protected int getNumberPendingSlotRequests() {
- return slotManager.getNumberPendingSlotRequests();
+ protected int getNumberRequiredTaskManagerSlots() {
+ return slotManager.getNumberPendingTaskManagerSlots();
+ }
+
+ // ------------------------------------------------------------------------
+ // Helper methods
+ // ------------------------------------------------------------------------
+
+ protected static Collection<ResourceProfile> createSlotsPerWorker(int numSlots) {
+ final Collection<ResourceProfile> slots = new ArrayList<>(numSlots);
Review comment:
It would be enough to write:
`Collections.nCopies(numSlots, ResourceProfile.ANY);`
The returned `List` is also immutable. At the moment there is no need to return a mutable list. I would even say it is not right that after calling `Collection<ResourceProfile> startNewWorker(ResourceProfile resourceProfile)`, one may potentially modify the state of the ResourceManager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services