You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/05 18:15:30 UTC
[GitHub] [trafficserver] randall opened a new pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
randall opened a new pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090#issuecomment-772902762
Cherry-picked to v9.1.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zizhong commented on pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
Posted by GitBox <gi...@apache.org>.
zizhong commented on pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090#issuecomment-671651784
I guess this way the plugin, like conf-remap, can use the same definition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090#issuecomment-769442739
[approve ci]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090#issuecomment-669984914
I threw the dice and chose that one. Really it seems better that it should be in HttpProxyAPIEnums.h.
I threw up this PR because I ran across this yesterday and thought it was kind of a WTF and was hoping the community had a better idea what's going on here (since it's the only struct/typedef like this)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090#issuecomment-676453633
Everyone agree now this is good? Don't want to jump the gun by approving.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090#issuecomment-670256290
@SolidWallOfCode @shinrich I'd like to hear opinions from people who added this file and the guard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090#issuecomment-671425113
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090#issuecomment-669619172
Can you tell me why you chose to keep the one in apidefs.h.in ?
A comment in HttpProxyAPIEnums.h says "Traffic Server SDK API - HTTP related enumerations". I'm not sure which file I should edit when I want to add some enumeration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall merged pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090#issuecomment-672859216
I'm trying to remember. Clearly the enum is in "apidefs.h" so it is available to plugins. I think it was elsewhere both because of legacy (it had always been there) and to avoid additional dependencies (e.g., any core code that needs to use those values must include all of "apidefs.h"). Maybe things have changed elsewhere, but I know I tried doing this earlier and it didn't compile for lack of that include, but I don't see such a change in your PR. If this works without such a change it seems reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org