You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2022/04/11 19:12:00 UTC

[jira] [Commented] (CALCITE-5085) New Firebolt Dialect

    [ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520773#comment-17520773 ] 

Julian Hyde commented on CALCITE-5085:
--------------------------------------

Raghav, Your message in the [dev thread|https://lists.apache.org/thread/v8whd5v0m4k4q3od2h1x6dv006x1rzms] indicates that there are bugs. I don't think I'll have time to help you fix those.

A couple of comments about your PR as it stands:
* There's no need to duplicate javadoc on overriding methods. I suggest to remove those javadoc comments.
* There are a lot of whitespace changes in RelToRelConverterTest. Please back those out.

> New Firebolt Dialect
> --------------------
>
>                 Key: CALCITE-5085
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5085
>             Project: Calcite
>          Issue Type: New Feature
>          Components: jdbc-adapter
>            Reporter: Kevin Marr
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Firebolt is a columnar MPP cloud data warehouse with decoupled storage and compute. https://www.firebolt.io/
> It closely follows PostgreSQL but has enough differences to warrant a separate dialect in Calcite. We would like to add this dialect to make it easier for any BI/modeling vendors using Calcite to implement Firebolt connectors.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)