You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/26 18:42:04 UTC
[jira] [Commented] (BEAM-2372) Only run Apache RAT at root module
[ https://issues.apache.org/jira/browse/BEAM-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026659#comment-16026659 ]
ASF GitHub Bot commented on BEAM-2372:
--------------------------------------
GitHub user dhalperi opened a pull request:
https://github.com/apache/beam/pull/3240
[BEAM-2372] Only run Apache RAT at root pom.xml
Since it checks the entire project anyway.
R: @davorbonaci @jbonofre
CC: @kennknowles @robertwb (as possibly-interested parties)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/beam rat-root-only
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3240
----
commit 764ae5291a57be96c20a9c9c0c66821d87bfc1b0
Author: Dan Halperin <dh...@google.com>
Date: 2017-05-26T18:40:38Z
[BEAM-2372] Only run Apache RAT at root pom.xml
Since it checks the entire project anyway.
----
> Only run Apache RAT at root module
> ----------------------------------
>
> Key: BEAM-2372
> URL: https://issues.apache.org/jira/browse/BEAM-2372
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Daniel Halperin
> Assignee: Daniel Halperin
> Fix For: Not applicable
>
>
> Apache RAT checks all files in the project, yet we run it at the root and then again in every submodule. This seems overkill.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)