You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jackye1995 (via GitHub)" <gi...@apache.org> on 2024/02/01 19:58:22 UTC
[I] RewriteManifest with more options [iceberg]
jackye1995 opened a new issue, #9615:
URL: https://github.com/apache/iceberg/issues/9615
### Feature Request / Improvement
from devlist discussion https://lists.apache.org/thread/x2rqfck4nz78j0fmz4sdchr5wxoywm29
I think we are landing in some experience like (e.g. in Spark):
```
SparkActions.rewriteManifests(table)
.sort("b", "a")
.commit()
```
```
SparkActions.rewriteManifests(table)
.sort(partitionData -> string)
.minManifests(20)
.maxManifests(40)
.targetManifestSize(8MB)
.commit()
```
so that users can more flexibly fine tune the sorting and colocation behaviors they want for the Iceberg metadata tree
### Query engine
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "ZachDischner (via GitHub)" <gi...@apache.org>.
ZachDischner commented on issue #9615:
URL: https://github.com/apache/iceberg/issues/9615#issuecomment-2411398358
Still open and would like to incorporate this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on issue #9615:
URL: https://github.com/apache/iceberg/issues/9615#issuecomment-1922298057
This looks great to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "zachdisc (via GitHub)" <gi...@apache.org>.
zachdisc commented on issue #9615:
URL: https://github.com/apache/iceberg/issues/9615#issuecomment-1932280121
Love the idea, I can take a crack at it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "zachdisc (via GitHub)" <gi...@apache.org>.
zachdisc commented on issue #9615:
URL: https://github.com/apache/iceberg/issues/9615#issuecomment-2842303837
I'm working on the last comments for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "zachdisc (via GitHub)" <gi...@apache.org>.
zachdisc commented on issue #9615:
URL: https://github.com/apache/iceberg/issues/9615#issuecomment-1946943705
Okay first cut at the simple version is in PR above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #9615:
URL: https://github.com/apache/iceberg/issues/9615#issuecomment-2408755169
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "zachdisc (via GitHub)" <gi...@apache.org>.
zachdisc commented on issue #9615:
URL: https://github.com/apache/iceberg/issues/9615#issuecomment-1934514656
Looking at the base API interface and core implementation, there is a [ClusterBy](https://github.com/apache/iceberg/blob/90d1c90b6e6f26fdfe7c0c6c09a1ecb2fc2b3f2a/core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java#L116) interface that is simply missing from the SparkActions implementation.
I think the API Jack proposed is cleaner, but it is probably more correct to just implement the same `clusterBy` interface. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer closed issue #9615: RewriteManifest with more options
URL: https://github.com/apache/iceberg/issues/9615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #9615:
URL: https://github.com/apache/iceberg/issues/9615#issuecomment-2803390415
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #9615:
URL: https://github.com/apache/iceberg/issues/9615#issuecomment-2840508526
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] RewriteManifest with more options [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #9615: RewriteManifest with more options
URL: https://github.com/apache/iceberg/issues/9615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org