[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #863: feature: Allow modify content(body&header) from upstream, can also support CORS

[GitBox <gi...@apache.org>]

lilien1010 commented on a change in pull request #863: feature: Allow modify content(body&header) from upstream, can also support CORS
URL: https://github.com/apache/incubator-apisix/pull/863#discussion_r347114499
 
 

 ##########
 File path: conf/config.yaml
 ##########
 @@ -88,6 +88,7 @@ plugins:                          # plugin list
   - openid-connect
   - proxy-rewrite
   - redirect
+  - response-rewrite
 
 Review comment:
   I think  it better to indicate one plugin use the same name
    while name is already defined in response-rewrite.lua
   `plugin_name = "response-rewrite"` 
   
   if we change it in `conf/config.yaml` , it wont pass the test case

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services