[jira] [Resolved] (SPARK-22982) Remove unsafe asynchronous close() call from FileDownloadChannel

["Wenchen Fan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-22982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wenchen Fan resolved SPARK-22982.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 2.3.0

Issue resolved by pull request 20179
[https://github.com/apache/spark/pull/20179]

> Remove unsafe asynchronous close() call from FileDownloadChannel
> ----------------------------------------------------------------
>
>                 Key: SPARK-22982
>                 URL: https://issues.apache.org/jira/browse/SPARK-22982
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 1.6.0, 2.0.0, 2.1.0, 2.2.0
>            Reporter: Josh Rosen
>            Assignee: Josh Rosen
>            Priority: Blocker
>              Labels: correctness
>             Fix For: 2.3.0
>
>
> Spark's Netty-based file transfer code contains an asynchronous IO bug which may lead to incorrect query results.
> At a high-level, the problem is that an unsafe asynchronous `close()` of a pipe's source channel creates a race condition where file transfer code closes a file descriptor then attempts to read from it. If the closed file descriptor's number has been reused by an `open()` call then this invalid read may cause unrelated file operations to return incorrect results due to reading different data than intended.
> I have a small, surgical fix for this bug and will submit a PR with more description on the specific race condition / underlying bug.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org