You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/21 23:44:14 UTC
[GitHub] [airflow] kaxil opened a new pull request #7494: [AIRFLOW-6789]
BugFix: Fix Default Worker concurrency
kaxil opened a new pull request #7494: [AIRFLOW-6789] BugFix: Fix Default Worker concurrency
URL: https://github.com/apache/airflow/pull/7494
https://github.com/apache/airflow/commit/9b5dbf9886df3977b24c95cadb99bbece9f8ce4b#diff-bbf16e7665ac448883f2ceeb40db35cdR444 commit in airflow 1.10.8 (1.10.9) introduced a bug. It changed default worker concurrency
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7494: [AIRFLOW-6789] BugFix:
Fix Default Worker concurrency
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7494: [AIRFLOW-6789] BugFix: Fix Default Worker concurrency
URL: https://github.com/apache/airflow/pull/7494#issuecomment-589883416
This only exists in 1.10.8/1.10.9 (v1-10-* branches). Master does not have this bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7494: [AIRFLOW-6789]
BugFix: Fix Default Worker concurrency
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7494: [AIRFLOW-6789] BugFix: Fix Default Worker concurrency
URL: https://github.com/apache/airflow/pull/7494#issuecomment-589944955
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7494?src=pr&el=h1) Report
> Merging [#7494](https://codecov.io/gh/apache/airflow/pull/7494?src=pr&el=desc) into [v1-10-test](https://codecov.io/gh/apache/airflow/commit/0d2aa85aca13b2aaa4c80bd9a54739bedc8bf98d?src=pr&el=desc) will **increase** coverage by `0.37%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7494?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-test #7494 +/- ##
==============================================
+ Coverage 80.96% 81.34% +0.37%
==============================================
Files 529 529
Lines 36437 36437
==============================================
+ Hits 29502 29640 +138
+ Misses 6935 6797 -138
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7494?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7494/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `91.84% <0%> (-0.17%)` | :arrow_down: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7494/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `66.91% <0%> (-0.11%)` | :arrow_down: |
| [...etes\_request\_factory/kubernetes\_request\_factory.py](https://codecov.io/gh/apache/airflow/pull/7494/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMva3ViZXJuZXRlc19yZXF1ZXN0X2ZhY3Rvcnkva3ViZXJuZXRlc19yZXF1ZXN0X2ZhY3RvcnkucHk=) | `100% <0%> (+0.86%)` | :arrow_up: |
| [airflow/contrib/kubernetes/pod.py](https://codecov.io/gh/apache/airflow/pull/7494/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcG9kLnB5) | `100% <0%> (+4.16%)` | :arrow_up: |
| [airflow/contrib/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7494/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcmVmcmVzaF9jb25maWcucHk=) | `74.5% <0%> (+23.52%)` | :arrow_up: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7494/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `96.84% <0%> (+40%)` | :arrow_up: |
| [airflow/contrib/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7494/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcG9kX2dlbmVyYXRvci5weQ==) | `87.5% <0%> (+45%)` | :arrow_up: |
| [airflow/contrib/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7494/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcG9kX2xhdW5jaGVyLnB5) | `92.48% <0%> (+47.36%)` | :arrow_up: |
| [airflow/contrib/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7494/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvdm9sdW1lLnB5) | `100% <0%> (+50%)` | :arrow_up: |
| [airflow/contrib/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7494/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvdm9sdW1lX21vdW50LnB5) | `100% <0%> (+66.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7494?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7494?src=pr&el=footer). Last update [0d2aa85...e4f68fb](https://codecov.io/gh/apache/airflow/pull/7494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7494: [AIRFLOW-6789] BugFix:
Fix Default Worker concurrency
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7494: [AIRFLOW-6789] BugFix: Fix Default Worker concurrency
URL: https://github.com/apache/airflow/pull/7494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services