[GitHub] [apisix-helm-chart] membphis commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534030123



##########
File path: chart/apisix/values.yaml
##########
@@ -95,34 +102,51 @@ admin:
     admin: edd1c9f034335f136f87ad84b625c8f1
     viewer: 4054f7cf07e344346cd3f287985e76a2
 
+allow:
+  # The ip range for allowing access to Apache APISIX
+  ipList:
+    - 127.0.0.1/24
+
 # APISIX plugins to be enabled
 plugins:
-  - example-plugin
-  - limit-req
-  - limit-count
-  - limit-conn
-  - key-auth
+  - api-breaker
+  - authz-keycloak
   - basic-auth
-  - prometheus
-  - node-status
-  - jwt-auth
-  - zipkin
-  - ip-restriction
+  - batch-requests
+  - consumer-restriction
+  - cors
+  - echo
+  - fault-injection
   - grpc-transcode
-  - serverless-pre-function
-  - serverless-post-function
+  - hmac-auth
+  - http-logger
+  - ip-restriction
+  - jwt-auth
+  - kafka-logger
+  - key-auth
+  - limit-conn
+  - limit-count
+  - limit-req
+  - node-status
   - openid-connect
+  - prometheus
+  - proxy-cache
+  - proxy-mirror
   - proxy-rewrite
   - redirect
+  - referer-restriction
+  - request-id
+  - request-validation
   - response-rewrite
-  - fault-injection
+  - serverless-post-function
+  - serverless-pre-function
+  - sls-logger
+  - syslog
+  - tcp-logger
   - udp-logger
+  - uri-blocker
   - wolf-rbac
-  - proxy-cache
-  - tcp-logger
-  - proxy-mirror
-  - kafka-logger
-  - cors
+  - zipkin
 stream_plugins:

Review comment:
       ditto

##########
File path: chart/apisix/values.yaml
##########
@@ -95,34 +102,51 @@ admin:
     admin: edd1c9f034335f136f87ad84b625c8f1
     viewer: 4054f7cf07e344346cd3f287985e76a2
 
+allow:
+  # The ip range for allowing access to Apache APISIX
+  ipList:
+    - 127.0.0.1/24
+
 # APISIX plugins to be enabled
 plugins:

Review comment:
       I think we can delete `plugins`, use the default list should be enough

##########
File path: chart/apisix/Chart.yaml
##########
@@ -31,9 +31,16 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.0
+version: 2.1.0
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 1.16.0
+appVersion: 2.1.0
+
+dependencies:
+  - name: etcd
+    version: 5.2.1

Review comment:
       `5.2.1`? I am confused with this version value




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org