[GitHub] [hudi] danny0405 commented on a change in pull request #4879: # modify the flink SmallFile list get error when async-compaction has been configured

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #4879:
URL: https://github.com/apache/hudi/pull/4879#discussion_r812633423



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/profile/DeltaWriteProfile.java
##########
@@ -59,7 +59,7 @@ public DeltaWriteProfile(HoodieWriteConfig config, HoodieFlinkEngineContext cont
       List<FileSlice> allSmallFileSlices = new ArrayList<>();
       // If we can index log files, we can add more inserts to log files for fileIds including those under
       // pending compaction.
-      List<FileSlice> allFileSlices = fsView.getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), true)
+      List<FileSlice> allFileSlices = fsView.getLatestFileSlicesBeforeOrOnForFlink(partitionPath, latestCommitTime.getTimestamp(), true)
           .collect(Collectors.toList());
       for (FileSlice fileSlice : allFileSlices) {

Review comment:
       Thanks, let's just make this flag as false, just like what `SparkUpsertDeltaCommitPartitioner` does: https://github.com/apache/hudi/blob/4e8accc179d8f60c874d748167018196900b7d12/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/deltacommit/SparkUpsertDeltaCommitPartitioner.java#L95




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org