You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Bryan Bende <bb...@gmail.com> on 2016/05/04 20:46:31 UTC
Review Request 46995: RANGER-968: Remove validation of email
addresses from UserMgr
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46995/
-----------------------------------------------------------
Review request for ranger.
Repository: ranger
Description
-------
Remove validation of email addresses from UserMgr to allow usergroup sync to create users from a file source where the email can't be specified.
Email is already not required when manually creating an email address in the user interface.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java d96aa05
Diff: https://reviews.apache.org/r/46995/diff/
Testing
-------
Full build passed, ran the application and verified the sync utility worked with file source, also verified a user could be created manually through the UI.
Thanks,
Bryan Bende
Re: Review Request 46995: RANGER-968: Remove validation of email
addresses from UserMgr
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46995/#review131750
-----------------------------------------------------------
Ship it!
Ship It!
- Don Bosco Durai
On May 4, 2016, 8:46 p.m., Bryan Bende wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46995/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 8:46 p.m.)
>
>
> Review request for ranger.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Remove validation of email addresses from UserMgr to allow usergroup sync to create users from a file source where the email can't be specified.
>
> Email is already not required when manually creating an email address in the user interface.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java d96aa05
>
> Diff: https://reviews.apache.org/r/46995/diff/
>
>
> Testing
> -------
>
> Full build passed, ran the application and verified the sync utility worked with file source, also verified a user could be created manually through the UI.
>
>
> Thanks,
>
> Bryan Bende
>
>
Re: Review Request 46995: RANGER-968: Remove validation of email
addresses from UserMgr
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46995/#review131751
-----------------------------------------------------------
Ship it!
Ship It!
- Sailaja Polavarapu
On May 4, 2016, 8:46 p.m., Bryan Bende wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46995/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 8:46 p.m.)
>
>
> Review request for ranger.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Remove validation of email addresses from UserMgr to allow usergroup sync to create users from a file source where the email can't be specified.
>
> Email is already not required when manually creating an email address in the user interface.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java d96aa05
>
> Diff: https://reviews.apache.org/r/46995/diff/
>
>
> Testing
> -------
>
> Full build passed, ran the application and verified the sync utility worked with file source, also verified a user could be created manually through the UI.
>
>
> Thanks,
>
> Bryan Bende
>
>